Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel-debs: fix: don't try to package linux-libc-dev if only packaging dtb #6464

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Apr 2, 2024

kernel-debs: fix: don't try to package linux-libc-dev if only packaging dtb

  • kernel-debs: fix: don't try to package linux-libc-dev if only packaging dtb
    Fixes: 22511b3

@github-actions github-actions bot added the size/small PR with less then 50 lines label Apr 2, 2024
@rpardini rpardini marked this pull request as ready for review April 2, 2024 19:44
@rpardini rpardini requested a review from a team as a code owner April 2, 2024 19:44
@ColorfulRhino
Copy link
Collaborator

Looking good

@pyavitz
Copy link
Collaborator

pyavitz commented Apr 2, 2024

Why is this package even being provided? It is already available in each distro.

@SteeManMI
Copy link
Contributor

Why is this package even being provided? It is already available in each distro.

@pyavitz See #6408 for the discussion on the recent re-addition of this package

@pyavitz
Copy link
Collaborator

pyavitz commented Apr 3, 2024

Why is this package even being provided? It is already available in each distro.

@pyavitz See #6408 for the discussion on the recent re-addition of this package

Thanx.

In my opinion linux-libc-dev should always be created when building an armbian kernel

I don't see why.

as the kernel versions often differ greatly from the ones natively in the distros.

Is that actually a problem?

I build kernels all the time and run them on focal to noble and bullseye to bookworm and beyond. I have yet to experience a problem that would require me to install this package.

linux-headers always installs linux-libc-dev as a dependency, so it is not enough. headers provided by linux-libc-dev are used by almost all libraries and programs (e.g. openssl, libc, samba, curl,....).

By this logic, wouldn't it make more sense that we use the linux-libc-dev that those libs and programs are expecting?


This is yet another case of Armbian creating problems for itself.

@amazingfate
Copy link
Contributor

I build kernels all the time and run them on focal to noble and bullseye to bookworm and beyond. I have yet to experience a problem that would require me to install this package.

For example, AV1 stateless v4l2 uAPI is merged to v6.5, if I want to build gstreamer/ffmpeg/chromium supporting stateless v4l2 av1 decoding I have to install linux-libc-dev, but this package in jammy is 5.15. If edge mainline kernel doesn't provide this package, this is a not full-featured kernel.

@pyavitz
Copy link
Collaborator

pyavitz commented Apr 3, 2024

I build kernels all the time and run them on focal to noble and bullseye to bookworm and beyond. I have yet to experience a problem that would require me to install this package.

For example, AV1 stateless v4l2 uAPI is merged to v6.5, if I want to build gstreamer/ffmpeg/chromium supporting stateless v4l2 av1 decoding I have to install linux-libc-dev, but this package in jammy is 5.15. If edge mainline kernel doesn't provide this package, this is a not full-featured kernel.

Is this provided via PPA?

@amazingfate
Copy link
Contributor

I build kernels all the time and run them on focal to noble and bullseye to bookworm and beyond. I have yet to experience a problem that would require me to install this package.

For example, AV1 stateless v4l2 uAPI is merged to v6.5, if I want to build gstreamer/ffmpeg/chromium supporting stateless v4l2 av1 decoding I have to install linux-libc-dev, but this package in jammy is 5.15. If edge mainline kernel doesn't provide this package, this is a not full-featured kernel.

Is this provided via PPA?

I packaged chromium with v4l2-request support in a ppa for jammy: https://launchpad.net/~liujianfeng1994/+archive/ubuntu/chromium. You can see there is a linux package which provides only one deb linux-libc-dev for stateless v4l2 uAPI that chromium uses. I may stop these backporting works because noble is coming and bookworm-backports has updated linux-libc-dev to 6.6.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels Apr 3, 2024
@rpardini
Copy link
Member Author

rpardini commented Apr 3, 2024

By this logic, wouldn't it make more sense that we use the linux-libc-dev that those libs and programs are expecting?

I tried, I removed it during armbian-next, then fought for 2 years for sanity, but simply gave up during #6408 (review) -- there's only so much one single person can defend. I'm sorry.

@rpardini rpardini merged commit e83d1a0 into armbian:main Apr 3, 2024
@rpardini
Copy link
Member Author

rpardini commented Apr 4, 2024

More reports (by @iav ) of trouble with this package -- seems it's missing Conflicts: line and breaks immediately when installed. Phew

@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Apr 4, 2024

More reports (by @iav ) of trouble with this package -- seems it's missing Conflicts: line and breaks immediately when installed. Phew

I vote for reverting 22511b3 since it also needlessly clutters the output/debs folder with a bunch of linux-libc-dev*.deb files after building a few times.
But in the end that's not on me to decide.

Maybe instead we can make it an installable package in the Armbian apt repo? So it's not built by default, but one can install it with apt install. Not sure how far the automated systems are built for this scenario though.

@pyavitz
Copy link
Collaborator

pyavitz commented Apr 4, 2024

Could this not be given a flag LIBC_DEV=true or whatever suites everyone and with that @amazingfate can add it to the PPA and base users can move on with their lives and not worry about this failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

6 participants