Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(releases): add Matrix/pcm v1 #115

Merged
merged 55 commits into from
Sep 29, 2020
Merged

docs(releases): add Matrix/pcm v1 #115

merged 55 commits into from
Sep 29, 2020

Conversation

317brian
Copy link
Contributor

No description provided.

@kevinawoo
Copy link
Contributor

@brian-armory wdyt about a columns saying something like:

  • supported by: Armory Backed, Community Backed
  • feature status: alpha, beta, stable, deprecated, etc

@317brian
Copy link
Contributor Author

Nice @kevinawoo. I'm thinking we should split up infra and features into different pages

@kevinawoo
Copy link
Contributor

kevinawoo commented Jul 20, 2020 •
edited
Loading

oh! have feature status link to our public feature definition. Here's the internal one

@andrewbackes
Copy link
Contributor

This is a great starting place!

In the past we've gotten bit pretty hard by different versions of the tools that we integrate with. Such as BitBucket Cloud 2.14 vs 2.13 or Kubernetes 1.11+ or Jenkins 2.x vs 1.x.

Would there be a way to incorporate those versions as well?

@317brian
Copy link
Contributor Author

Yeah, we can put in a version column like the Database example

@alchen99
Copy link
Contributor

We should add dynamic accounts (spinnaker external account configuration) and what backends we support. For, example Vault

alchen99
alchen99 reviewed Jul 24, 2020
View reviewed changes
content/en/docs/combined-matrix.md Outdated Show resolved Hide resolved
content/en/docs/combined-matrix.md Outdated Show resolved Hide resolved
content/en/docs/compatibility-matrix.md Outdated Show resolved Hide resolved
content/en/docs/compatibility-matrix.md Outdated Show resolved Hide resolved
content/en/docs/compatibility-matrix.md Outdated Show resolved Hide resolved
jasonmcintosh
jasonmcintosh reviewed Sep 2, 2020
View reviewed changes
content/en/docs/combined-matrix.md Outdated
| Webhook secret validation | 2.20 or later | |
| Local modules for development | 2.20 or later | |
| [Pull Request Validation]({{< ref "install-dinghy#pull-request-validations" >}}) | 2.21 or later | |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also support pub/sub
jenkins triggers
Jenkins CI
Fiat managed service account ingegration (replaces legacy "service account" stuff)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dogonthehorizon is the PUX team 👍 on officially supporting these?

danielpeach
danielpeach reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@danielpeach danielpeach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing to confirm that the matrix is correct for artifacts. I left a comment under each artifact type with the PR that introduced the type. In the cases where the PR was tagged with the target release version, I included the version (if the PR wasn't tagged, it means the feature has been around at least since 1.9 or something).

content/en/docs/combined-matrix.md Outdated

| Type | Armory | Notes |
|------------------------------------------------------------------------------------------------------------------|------------------------|-------------------------------------------|
| [Bitbucket file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/bitbucket-file/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2674

content/en/docs/combined-matrix.md Outdated
| Type | Armory | Notes |
|------------------------------------------------------------------------------------------------------------------|------------------------|-------------------------------------------|
| [Bitbucket file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/bitbucket-file/) | All supported versions | |
| [Docker Image](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/docker-image/) | All supported versions | Can be hosted on DockerHub, GCR, ECR, etc |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#3424

content/en/docs/combined-matrix.md Outdated
|------------------------------------------------------------------------------------------------------------------|------------------------|-------------------------------------------|
| [Bitbucket file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/bitbucket-file/) | All supported versions | |
| [Docker Image](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/docker-image/) | All supported versions | Can be hosted on DockerHub, GCR, ECR, etc |
| [Embedded Base64](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/embedded-base64/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2416

content/en/docs/combined-matrix.md Outdated
| [Bitbucket file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/bitbucket-file/) | All supported versions | |
| [Docker Image](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/docker-image/) | All supported versions | Can be hosted on DockerHub, GCR, ECR, etc |
| [Embedded Base64](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/embedded-base64/) | All supported versions | |
| [GCS Object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/gcs-object/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2218

content/en/docs/combined-matrix.md Outdated
| [Docker Image](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/docker-image/) | All supported versions | Can be hosted on DockerHub, GCR, ECR, etc |
| [Embedded Base64](https://spinnaker.io/reference/artifacts-with-artifactsrewrite/types/embedded-base64/) | All supported versions | |
| [GCS Object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/gcs-object/) | All supported versions | |
| [Git Repo](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/git-repo/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#4049 (since 1.17)

content/en/docs/combined-matrix.md Outdated
| [Git Repo](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/git-repo/) | All supported versions | |
| [GitHub file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/github-file/) | All supported versions | |
| [GitLab file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/gitlab-file/) | All supported versions | |
| [HTTP file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/http-file/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2395

content/en/docs/combined-matrix.md Outdated
| [GitHub file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/github-file/) | All supported versions | |
| [GitLab file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/gitlab-file/) | All supported versions | |
| [HTTP file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/http-file/) | All supported versions | |
| [Kubernetes object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/kubernetes-object/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#3424 (since 1.13)

content/en/docs/combined-matrix.md Outdated
| [GitLab file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/gitlab-file/) | All supported versions | |
| [HTTP file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/http-file/) | All supported versions | |
| [Kubernetes object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/kubernetes-object/) | All supported versions | |
| [Maven artifact](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/maven-artifact/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#3177 (since 1.11)

content/en/docs/combined-matrix.md Outdated
| [HTTP file](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/http-file/) | All supported versions | |
| [Kubernetes object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/kubernetes-object/) | All supported versions | |
| [Maven artifact](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/maven-artifact/) | All supported versions | |
| [Oracle Object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/oracle-object/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2990 (since 1.10)

content/en/docs/combined-matrix.md Outdated
| [Kubernetes object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/kubernetes-object/) | All supported versions | |
| [Maven artifact](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/maven-artifact/) | All supported versions | |
| [Oracle Object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/oracle-object/) | All supported versions | |
| [S3 object](https://www.spinnaker.io/reference/artifacts-with-artifactsrewrite/types/s3-object/) | All supported versions | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnaker/clouddriver#2468

@317brian
Copy link
Contributor Author

317brian commented Sep 21, 2020 •
edited
Loading

Thanks @danielpeach. This initial iteration of the matrix is pretty labor intensive. It should be easier going forward since we'll only have to make minor updates/changes instead of creating something from scratch.

I'm not clear on the purpose of automating this process going forward. Something being added to the a Spinnaker release and available in OSS is not the same as Armory supporting/recommending it. The most obvious example is probably MPTv2 where we go out of our way to disable the UI by default.

kevinawoo and others added 9 commits September 23, 2020 20:09
@kevinawoo
cleanup markdown table syntax
ae60548
@317brian
commenting out the observability section. it is in limbo until the ob…
b19a461 
…servability plugin gets some tlc
@kevinawoo
Merge branch 'master' into matrix/pcm-v1
cf0dac1 
* master: (40 commits)
  docs(installation): clarifications added on Halyard Versions (#220)
  feat(armory.io): add Aurora links to AWS (#216)
  docs(fix): fix typo in naming conventions (#217)
  docs(saas): reorganize and rewrite content in preparation for saas (#211)
  Update deploy.md
  chore(release): add release notes for 2.20.6 (#215)
  fix(docs): missing syntax in example (#214)
  docs(pipelines): remove unused demo pipelines feature (#213)
  chore(secrets): make vault k8s auth more friendly (#212)
  Update _index.md (#210)
  chore(release): add release notes for 2.21.4 (#209)
  docs(fix): add redirect (#208)
  docs(saas): split up policy engine docs in preparation for saas (#205)
  docs(artifactory): Update operator docs for artifactory  (#207)
  fix(terraformer): yaml examples for named profiles (#206)
  docs(release): add breaking change for k8s namespace (#203)
  docs(rename): rename Armory Spinnaker (#182)
  fix(installDinghy): Add GitHub Config (#201)
  docs(admin): Add 'Serving Gate on the Same Hostname as Deck' doc (#200)
  fix(rollback): Remove old rollback instructions (#199)
  ...
@aimeeu
Fix install_dingy and policy_engine broke page links
d83c0b6 
Pages were renamed in a prior PR
@kevinawoo
cleanup trailing whitespaces
9353569
@kevinawoo
Merge branch 'matrix/pcm-v1' of https://github.com/armory/docs into m…
d8ae8e9 
…atrix/pcm-v1

* 'matrix/pcm-v1' of https://github.com/armory/docs:
  Fix install_dingy and policy_engine broke page links
@kevinawoo
reformat markdown tables, removing ":" in dividors
6676e7b
@kevinawoo
reformat markdown tables, removing ":" in dividors
6f21832
@kevinawoo
feat(pcm): add clouddriver and gate (#228)
89288e0
@317brian 317brian marked this pull request as ready for review September 29, 2020 04:32
@317brian 317brian requested a review from a team as a code owner September 29, 2020 04:32
@317brian 317brian merged commit 237d028 into master Sep 29, 2020
@317brian 317brian deleted the matrix/pcm-v1 branch September 29, 2020 17:09
317brian added a commit that referenced this pull request Oct 12, 2020
@317brian @dogonthehorizon
@aelath @kevinawoo @aimeeu
docs(releases): add Matrix/pcm v1 (#115)
8825af2 
Co-authored-by: brian-armory <brian.le@armory.io>
Co-authored-by: Andrew Way <away@armory.io>
Co-authored-by: Cameron Motevasselani <cameron@armory.io>
Co-authored-by: Fernando Freire <fernando.freire@armory.io>
Co-authored-by: Jacob Kobernik <jacob.kobernik@armory.io>
Co-authored-by: Mark Rampton <mark.rampton@armory.io>
Co-authored-by: Kevin Woo <kevinawoo@gmail.com>
Co-authored-by: Aimee Ukasick <aimeeu.opensource@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh left review comments

@aelath aelath aelath left review comments

@alchen99 alchen99 alchen99 left review comments

@danielpeach danielpeach danielpeach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@317brian @kevinawoo @andrewbackes @alchen99 @jasonmcintosh @aelath @danielpeach @dogonthehorizon @aimeeu