feat(artifacts): Add docker and kubernetes artifact types #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docker and kubernetes artifact types to
clouddriver-artifacts.Docker
Previously, Deck considered Docker artifacts to be publicly accessible, so always showed the Docker artifact type in the list of kinds selectable when creating new expected artifacts. Some cloud providers can't do anything with a Docker image though, so we want to be able to further conditionalize the display of this kind in the UI. We do that by only surfacing a (no credential) Docker artifact account from clouddriver when K8S is enabled. If other providers can do something with a Docker image, they can simply add to the
@ConditionalOnPropertyinDockerArtifactConfiguration.Kubernetes
Previously, Kubernetes resources needed to be defined with the Custom artifact editor in Deck. With spinnaker/deck#6634, a Kubernetes artifact editor has been added. We want to conditionalize when this editor is available in the UI, and so have added a similar
@ConditionalOnPropertytoKubernetesArtifactConfiguration.