refactor(artifacts): Combine expected artifacts and trigger artifact constraints #6634

jkschneider · 2019-03-02T22:55:46Z

See #6613 for details about why and further screenshots.

* Extracted body of spelAutocompleteService.service.js into a separate class and converted to Typescript * Tweaked CSS class of react-based expected artifact inputs that occur in K8S/AppEngine stage configurations to match the size of text seen elsewhere on those modals. * ExpectedArtifactEditor now takes as a property input an IPipeline (optionally) that is in turn used to populate expression suggestions.

…constraints

…er directive

…ors immediately

TODO: - user is unable to edit or remove expected artifacts created with the StageArtifactSelector

…nent

…reincarnate feat(artifacts): add a flag to hide the expected artifacts component

…deploy manifest stage

… account type

jkschneider · 2019-03-02T22:57:01Z

This is the "Deploy Manifest" stage after incorporating the new selector:

It adds requiredArtifacts and matchArtifact to the existing matchArtifactId and requiredArtifactIds. These fields are of type IArtifact and are present when one of the bindable artifacts or the match artifact are defined inline in the stage.

spinnakerbot · 2019-03-02T23:00:20Z

The following commits need their title changed:

506e9cf: Merge pull request single UI view for insight #1 from sbwsg/combine-artifacts-triggers-flag-and-reincarnate

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

* Assume that clouddriver will provide Docker artifact credentials if a cloud provider is configured that can use these kinds of artifacts. * Do not allow definition of a k8s artifact as a trigger artifact constraint. * Do not allow definition of a docker artifact as an inline "Deploy Manifest" manifest artifact.

…ests

…ectors

jkschneider · 2019-03-03T03:37:36Z

Here is a screenshot of the new Kubernetes artifact editor:

ghost · 2019-03-04T16:48:13Z

Looks like the unflagged experience is still a bit broken. In this screenshot the GCS editable input where I would enter the bucket's gs:// URL is missing from the inline editor:

Additionally looks as though adding an HTTP default artifact causes console errors with no input field showing up:

ghost

I'm still checking my existing pipelines on this branch to find any more breakages but am adding these first comments from a quick code review.

app/scripts/modules/core/src/pipeline/config/triggers/artifacts/docker/docker.artifact.ts

app/scripts/modules/core/src/pipeline/config/stages/stage.html

app/scripts/modules/core/src/domain/IArtifact.ts

app/scripts/modules/core/src/pipeline/config/triggers/artifacts/artifact.component.ts

app/scripts/modules/core/src/pipeline/config/PipelineRegistry.ts

app/scripts/modules/core/src/pipeline/config/stages/stage.module.js

ghost · 2019-03-04T17:02:49Z

I think I see the issue with the http default artifact - it looks like it shouldn't be presented there at all; it doesn't appear on master.

jkschneider · 2019-03-04T17:06:17Z

I think I see the issue with the http default artifact - it looks like it shouldn't be presented there at all; it doesn't appear on master.

yes, i suppose we are going to have to add an angular default http editor :/

app/scripts/modules/core/src/artifact/expectedArtifact.service.ts

app/scripts/modules/core/src/artifact/react/ExpectedArtifactEditor.tsx

app/scripts/modules/core/src/pipeline/config/triggers/artifacts/custom/CustomArtifactEditor.tsx

…feature flag

…rtifacts feature

… feature

jkschneider · 2019-03-04T21:21:51Z

@sbwsg I added a default HTTP editor so that works now:

…tifact delegate

ghost

hokay, code review looks good to me. I checked out the branch and ran through a few of my k8s and GAE pipelines that utilize artifacts (without the rewrite flag enabled). Clicking around and configuring the pipelines looks to be working as expected and running the pipelines continues to work just fine as well (I wasn't expecting any difference there but wanted to double check).

At this stage I think this should get merged. Let's keep an eye out for user reports of issues related to artifacts in the nightly builds and when 1.13 gets cut. I'm still a bit cautious that we might get reports of problems in artifact edge cases that we're either not aware of or don't exercise very often but I think we can deal with those if and when they surface.

#6672) * chore(core): Bump version to 0.0.343 eacfe75 feat(core): Warning message about invalid job params (#6669) a28f7af fix(core): Surface invalid params for a pipeline stage (#6668) e2b4d8e refactor(*): remove unused local storage caches (#6665) 35e82ac feat(core): Add support for an Artifactory Trigger (#6664) bc2bf43 feat(jenkins): Add artifact status tab to Jenkins execution details (#6666) e0bda86 feat(artifacts): Re-use artifacts when re-running a pipeline (#6663) 29582dd feat(core): Filter v2 pipeline templates from create pipeline modal (#6660) 45678a1 fix(core/pipeline): make cancelmodal take markdown for body (#6662) 02af17f fix(artifacts): Correct render-if-feature for new artifacts on stage 'produces artifact' (#6661) 0eb634c fix(artifacts): Maven/ivy reference field, Base64 validation, SpelText performance (#6656) 93e89be fix(core): Remove ability to trigger manual exec for mptv2 pipelines (#6651) d3209d4 feat(core): Add pipeline to IStageConfigProps (#6655) 1bc94a1 chore(angularjs): explicitly annotate more angularjs injections (#6653) 78d0aae fix(artifacts): save HTTP URL as artifact reference (#6650) 09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645) 8e9cb0b fix(core): titus run jobs override all other providers (#6647) 12e3bff fix(core): Remove configure button and setup redirect for mptv2 pipeline (#6644) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634) eae6b45 feat(users): Always surface authenticated user for executions/tasks (#6638) * chore(amazon): Bump version to 0.0.179 e2b4d8e refactor(*): remove unused local storage caches (#6665) 09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645) * chore(titus): Bump version to 0.0.79 e2b4d8e refactor(*): remove unused local storage caches (#6665)

1ada021 feat(kubernetes): expose rendered helm template in execution details (spinnaker#6943) d122749 feat(runJob/kubernetes): render external link (spinnaker#6930) 9e03e52 refactor(runJob/kubernetes): refactor exec details (spinnaker#6924) 98ca0ff refactor(runJob/kubernetes): use joblogviewer (spinnaker#6917) 6c5eed6 feat(provider/kubernetes): run job manifest artifacts (spinnaker#6902) cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model d44be0c fix(kubernetes): hide manifest artifact selector in text mode bd94593 feat(kubernetes): remove rollout strategies feature flag 0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled 37e24d7 fix(kubernetes): safer lookups for deploy stage validators (spinnaker#6847) 478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (spinnaker#6841) e618548 feat(preconfiguredJob): logs for k8s jobs (spinnaker#6840) c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (spinnaker#6839) 5640431 fix(k8s): Fix deploy manifest (spinnaker#6833) ee89a64 feat(kuberntes): v2 runJob (spinnaker#6831) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816) 33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794) 20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (spinnaker#6775) bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (spinnaker#6777) 50b74f2 feat(gcb): add Google Cloud Build stage (spinnaker#6774) 5b03078 fix(kubernetes): fix copy manifest from infrastructure button (spinnaker#6719) 57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (spinnaker#6691) a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (spinnaker#6696) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (spinnaker#6705) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (spinnaker#6634) 0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector 79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage 0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults 5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (spinnaker#6630) cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (spinnaker#6628) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 4b91b36 refactor(core): move Ace Editor CSS to core module (spinnaker#6588) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (spinnaker#6578) d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase

1ada021 feat(kubernetes): expose rendered helm template in execution details (#6943) d122749 feat(runJob/kubernetes): render external link (#6930) 9e03e52 refactor(runJob/kubernetes): refactor exec details (#6924) 98ca0ff refactor(runJob/kubernetes): use joblogviewer (#6917) 6c5eed6 feat(provider/kubernetes): run job manifest artifacts (#6902) cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model d44be0c fix(kubernetes): hide manifest artifact selector in text mode bd94593 feat(kubernetes): remove rollout strategies feature flag 0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled 37e24d7 fix(kubernetes): safer lookups for deploy stage validators (#6847) 478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (#6841) e618548 feat(preconfiguredJob): logs for k8s jobs (#6840) c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (#6839) 5640431 fix(k8s): Fix deploy manifest (#6833) ee89a64 feat(kuberntes): v2 runJob (#6831) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (#6816) 33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (#6820) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (#6794) 20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (#6775) bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (#6777) 50b74f2 feat(gcb): add Google Cloud Build stage (#6774) 5b03078 fix(kubernetes): fix copy manifest from infrastructure button (#6719) 57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (#6691) a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (#6696) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705) e2b4d8e refactor(*): remove unused local storage caches (#6665) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634) 0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector 79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage 0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults 5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (#6630) cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (#6628) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 4b91b36 refactor(core): move Ace Editor CSS to core module (#6588) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (#6578) d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase

Jon Schneider and others added 18 commits February 25, 2019 11:23

refactor(artifacts): Combine expected artifacts and trigger artifact …

3d7bd75

…constraints

refactor(artifacts): Produces artifacts on stage config

83688ed

fix(artifacts): StageArtifactSelector event handling

ee2fd61

fix(artifacts): trigger artifact constraint causes angular digest loop

b44a37b

fix(artifacts): handle undefined pipeline expected artifacts in trigg…

640d824

…er directive

Merge branch 'master' into combine-artifacts-triggers

5ea0628

fix(artifacts): don't attempt to set type on GCS/Github artifact edit…

27ff8e5

…ors immediately

fix(artifacts): patch gcs and github artifact editors

8ea2abe

feat(kubernetes): add StageArtifactSelector to deploy manifest stage

1437c1b

TODO: - user is unable to edit or remove expected artifacts created with the StageArtifactSelector

feat(artifacts): add a flag to show/hide the expected artifacts compo…

417219d

…nent

Merge pull request #1 from sbwsg/combine-artifacts-triggers-flag-and-…

506e9cf

…reincarnate feat(artifacts): add a flag to hide the expected artifacts component

fix(artifacts): correct lint issues I introduced in previous commit

e10e18b

feat(artifacts): Add StageArtifactSelectors for binding artifacts on …

0b3a06f

…deploy manifest stage

fix(artifacts): add back legacy trigger artifact constraints

3942bb0

fix(artifacts): Set type and custom kind early when changing artifact…

c57ea7d

… account type

Merge branch 'master' into combine-artifacts-triggers

6a684b2

fix(artifacts): Remove extraneous character

ff0beac

jkschneider requested a review from a user March 2, 2019 22:57

jkschneider changed the title ~~Combine artifacts triggers~~ refactor(artifacts): Combine expected artifacts and trigger artifact constraints Mar 2, 2019

jkschneider mentioned this pull request Mar 3, 2019

feat(artifacts): Add docker and kubernetes artifact types spinnaker/clouddriver#3424

Merged

Jon Schneider added 2 commits March 2, 2019 21:11

refactor(artifacts): Remove unused custom artifact kind default and t…

d41b37b

…ests

feat(artifacts): Exclude front50 artifact type from most artifact sel…

369be00

…ectors

fix(artifacts): Add typePattern to angular artifact editors

4dae303

jkschneider force-pushed the combine-artifacts-triggers branch from 75a2a99 to 4dae303 Compare March 3, 2019 03:48

fix(artifacts): Fix import on StageArtifactSelectdorin k8s module

30853f8

jkschneider force-pushed the combine-artifacts-triggers branch from 1e7547f to 30853f8 Compare March 3, 2019 14:29

Merge branch 'master' into combine-artifacts-triggers

34fe746

ghost suggested changes Mar 4, 2019

View reviewed changes

ghost reviewed Mar 4, 2019

View reviewed changes

app/scripts/modules/core/src/artifact/expectedArtifact.service.ts Outdated Show resolved Hide resolved

ghost reviewed Mar 4, 2019

View reviewed changes

Jon Schneider added 5 commits March 4, 2019 14:24

fix(artifacts): Reinstate produces artifacts behind legacy artifacts …

4dff562

…feature flag

fix(artifacts): Restore custom artifact editor as default in legacy a…

5ab4885

…rtifacts feature

fix(artifacts): Restore customKind behavior in ExpectedArtifactEditor

1f97ac2

chore(artifacts): Remove dangling comment in docker.artifact.ts

50dac9e

feat(artifacts): Add default HTTP artifact editor to legacy artifacts…

da3f652

… feature

Jon Schneider and others added 2 commits March 4, 2019 15:29

fix(artifacts): Restore custom artifact kind to kinds in GCE image ar…

c0e5f61

…tifact delegate

Merge branch 'master' into combine-artifacts-triggers

bb26fb7

ghost approved these changes Mar 5, 2019

View reviewed changes

Merge branch 'master' into combine-artifacts-triggers

de7e364

jkschneider merged commit 5da2965 into spinnaker:master Mar 5, 2019

spinnakerbot added the target-release/1.13 label Mar 5, 2019

anotherchrisberry mentioned this pull request Mar 12, 2019

Bump package core to 0.0.343 and amazon to 0.0.179 and titus to 0.0.79 #6672

Merged

maggieneterval mentioned this pull request May 10, 2019

chore(kubernetes): Bump version to 0.0.22 #6969

Merged

Jammy-Louie deleted the combine-artifacts-triggers branch May 21, 2019 14:58

maggieneterval mentioned this pull request Nov 7, 2019

fix(artifacts): enable inline editing of base64 artifacts #7612

Merged

maggieneterval mentioned this pull request May 12, 2020

refactor(core): legacy artifacts cleanup #8273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(artifacts): Combine expected artifacts and trigger artifact constraints #6634

refactor(artifacts): Combine expected artifacts and trigger artifact constraints #6634

jkschneider commented Mar 2, 2019 •

edited

Loading

jkschneider commented Mar 2, 2019

spinnakerbot commented Mar 2, 2019

jkschneider commented Mar 3, 2019

ghost commented Mar 4, 2019

ghost left a comment

ghost commented Mar 4, 2019

jkschneider commented Mar 4, 2019 •

edited

Loading

jkschneider commented Mar 4, 2019

ghost left a comment

refactor(artifacts): Combine expected artifacts and trigger artifact constraints #6634

refactor(artifacts): Combine expected artifacts and trigger artifact constraints #6634

Conversation

jkschneider commented Mar 2, 2019 • edited Loading

jkschneider commented Mar 2, 2019

spinnakerbot commented Mar 2, 2019

jkschneider commented Mar 3, 2019

ghost commented Mar 4, 2019

ghost left a comment

Choose a reason for hiding this comment

ghost commented Mar 4, 2019

jkschneider commented Mar 4, 2019 • edited Loading

jkschneider commented Mar 4, 2019

ghost left a comment

Choose a reason for hiding this comment

jkschneider commented Mar 2, 2019 •

edited

Loading

jkschneider commented Mar 4, 2019 •

edited

Loading