fix(html): Fix various invalid HTML #6599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gcomstock since you seem to care about this sort of thing :) |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
christopherthielen
added a commit
that referenced
this pull request
Feb 22, 2019
gcomstock
reviewed
Feb 22, 2019
| <console-output-link instance="instance"></console-output-link> | ||
| </li> | ||
| </ul> | ||
| </collapsible-section> |
There was a problem hiding this comment.
Why is this getting removed?
There was a problem hiding this comment.
good question, didn't mean to.
glad you reviewed this :)
gcomstock
reviewed
Feb 22, 2019
| <p class="clearfix"> | ||
| <div ng-if="event.status ==git ad= 'Success'"> | ||
| <p class="clearfix"></p> | ||
| <div ng-if="event.status === 'Success'"> |
There was a problem hiding this comment.
I dont know how these angular conditionals work but this change looks suspicious
There was a problem hiding this comment.
The old markup is nonsense and I suspect a typo:
<div ng-if="event.status ==git ad= 'Success'">
gcomstock
reviewed
Feb 22, 2019
| </p> | ||
| <ul> | ||
| <li ng-repeat="service in ctrl.command.getUnusedHealthChecks(ctrl.command)" ng-bind-html="service"></li> | ||
| </ul> |
There was a problem hiding this comment.
This p tag might be applying styles to the ul that we're losing here, worth a look
There was a problem hiding this comment.
I'm not worried about it. <ul> is not legal inside a <p> tag (only inline content is legal).
When the browser parses this, it puts the <ul> as a peer to (not inside of) the <p> tag.
There was a problem hiding this comment.
Look at that! Thanks for the tip.
| @@ -166,7 +166,6 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click> | |||
| <dd ng-repeat-end>{{value}}</dd> | |||
| </dl> | |||
| </collapsible-section> | |||
| </div> | |||
There was a problem hiding this comment.
suspicious? What do you mean?
There was a problem hiding this comment.
Just wanted to make sure prettier wasn't removing a closing tag erroneously and possibly breaking the layout. It wasn't obvious to me if this was just an extraneous tag or not.
There was a problem hiding this comment.
ah I see. This commit wasn't prettier, this was all by hand to fix the HTML spec issues prettier pointed out
There was a problem hiding this comment.
Ah! Sorry to waste yer time
maggieneterval
added a commit
to maggieneterval/deck
that referenced
this pull request
May 10, 2019
1ada021 feat(kubernetes): expose rendered helm template in execution details (spinnaker#6943) d122749 feat(runJob/kubernetes): render external link (spinnaker#6930) 9e03e52 refactor(runJob/kubernetes): refactor exec details (spinnaker#6924) 98ca0ff refactor(runJob/kubernetes): use joblogviewer (spinnaker#6917) 6c5eed6 feat(provider/kubernetes): run job manifest artifacts (spinnaker#6902) cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model d44be0c fix(kubernetes): hide manifest artifact selector in text mode bd94593 feat(kubernetes): remove rollout strategies feature flag 0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled 37e24d7 fix(kubernetes): safer lookups for deploy stage validators (spinnaker#6847) 478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (spinnaker#6841) e618548 feat(preconfiguredJob): logs for k8s jobs (spinnaker#6840) c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (spinnaker#6839) 5640431 fix(k8s): Fix deploy manifest (spinnaker#6833) ee89a64 feat(kuberntes): v2 runJob (spinnaker#6831) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816) 33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794) 20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (spinnaker#6775) bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (spinnaker#6777) 50b74f2 feat(gcb): add Google Cloud Build stage (spinnaker#6774) 5b03078 fix(kubernetes): fix copy manifest from infrastructure button (spinnaker#6719) 57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (spinnaker#6691) a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (spinnaker#6696) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (spinnaker#6705) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (spinnaker#6634) 0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector 79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage 0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults 5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (spinnaker#6630) cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (spinnaker#6628) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 4b91b36 refactor(core): move Ace Editor CSS to core module (spinnaker#6588) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (spinnaker#6578) d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
maggieneterval
added a commit
that referenced
this pull request
May 10, 2019
1ada021 feat(kubernetes): expose rendered helm template in execution details (#6943) d122749 feat(runJob/kubernetes): render external link (#6930) 9e03e52 refactor(runJob/kubernetes): refactor exec details (#6924) 98ca0ff refactor(runJob/kubernetes): use joblogviewer (#6917) 6c5eed6 feat(provider/kubernetes): run job manifest artifacts (#6902) cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model d44be0c fix(kubernetes): hide manifest artifact selector in text mode bd94593 feat(kubernetes): remove rollout strategies feature flag 0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled 37e24d7 fix(kubernetes): safer lookups for deploy stage validators (#6847) 478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (#6841) e618548 feat(preconfiguredJob): logs for k8s jobs (#6840) c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (#6839) 5640431 fix(k8s): Fix deploy manifest (#6833) ee89a64 feat(kuberntes): v2 runJob (#6831) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (#6816) 33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (#6820) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (#6794) 20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (#6775) bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (#6777) 50b74f2 feat(gcb): add Google Cloud Build stage (#6774) 5b03078 fix(kubernetes): fix copy manifest from infrastructure button (#6719) 57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (#6691) a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (#6696) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705) e2b4d8e refactor(*): remove unused local storage caches (#6665) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634) 0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector 79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage 0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults 5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (#6630) cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (#6628) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 4b91b36 refactor(core): move Ace Editor CSS to core module (#6588) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (#6578) d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (spinnaker#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861) 297cd99 feat(provider/google): Support Shielded VM policies (spinnaker#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (spinnaker#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (spinnaker#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (spinnaker#6751) 432e6e3 fix(google): add better help text around accelerators (spinnaker#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (spinnaker#6317) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (spinnaker#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (spinnaker#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) 1c61cb2 feat(ecs): service discovery configuration (spinnaker#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (spinnaker#6906) c550d82 feat(ecs): Configure tags (spinnaker#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (spinnaker#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (spinnaker#6746) 1c9e075 feat(ecs): docker image selection (spinnaker#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (spinnaker#6681) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (spinnaker#6251) e802c45 fix(*): allow modal to stay open on auto-close (spinnaker#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (spinnaker#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (spinnaker#5799)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861) 297cd99 feat(provider/google): Support Shielded VM policies (#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (#6751) 432e6e3 fix(google): add better help text around accelerators (#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (#6317) e2b4d8e refactor(*): remove unused local storage caches (#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 64fb489 fix(html): Fix various invalid HTML (#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) 1c61cb2 feat(ecs): service discovery configuration (#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (#6906) c550d82 feat(ecs): Configure tags (#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (#6746) 1c9e075 feat(ecs): docker image selection (#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (#6681) e2b4d8e refactor(*): remove unused local storage caches (#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (#6251) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (#5799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed some more invalid HTML
see #6597