-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" #6808
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@spinnakerbot cherry-pick 1.12 |
@spinnakerbot cherry-pick 1.13 |
Cherry pick failed: Command failed (cherry pick commit 728ddbe) with exit code 1:
|
Cherry pick successful: #6809 |
…ional gce server group (spinnaker#6751)" (spinnaker#6808) This reverts commit ad2e222. In hindsight, Deck was already doing the right thing here. GCP chooses the zones and, in some quick testing, the MIGs in us-central1 always seem to get spread across zones -b, -c, and -f.
* master: (28 commits) feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816) feat(cf): Create Service Key pipeline stage (spinnaker#6821) feat(core): Create pipeline from v2 template list fix(provider/cf): Clone model so Orca monitors the correct foundation for up instances (spinnaker#6817) chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820) fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (spinnaker#6818) feat(provider/azure): Add redblack strategy for azure (spinnaker#6801) fix(mptv2): clicking a view link on template list screen throws exception (spinnaker#6815) fix(artifacts): helm artifact, replace object assignw with object spread (spinnaker#6814) fix(provider/cf): Fix provider selection for resize stage in pipeline (spinnaker#6754) fix(artifacts): default helm artifact editor is broken (spinnaker#6811) fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808) fix(google): GCE create server group and load balancer fixes (spinnaker#6806) Bump package core to 0.0.350 and amazon to 0.0.184 (spinnaker#6807) fix(amazon): hide security groups on NLBs (spinnaker#6803) refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) fix(google): fix autohealing health checks in deploy stages (spinnaker#6804) fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794) fix(triggers): Add lastSuccessfulBuild as a build option in Jenkins default artifact (spinnaker#6797) fix(provider/cf): Make expected artifacts selectable as clone manifests (spinnaker#6796) ...
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (spinnaker#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861) 297cd99 feat(provider/google): Support Shielded VM policies (spinnaker#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (spinnaker#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (spinnaker#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (spinnaker#6751) 432e6e3 fix(google): add better help text around accelerators (spinnaker#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (spinnaker#6317) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (spinnaker#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (spinnaker#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861) 297cd99 feat(provider/google): Support Shielded VM policies (#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (#6751) 432e6e3 fix(google): add better help text around accelerators (#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (#6317) e2b4d8e refactor(*): remove unused local storage caches (#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 64fb489 fix(html): Fix various invalid HTML (#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
This reverts commit ad2e222.
In hindsight, Deck was already doing the right thing here. The platform, GCP, chooses the zones if the user doesn't specify them. In some quick testing through the GCP UI, MIGs in us-central1 always seem to get spread across zones -b, -c, and -f and never end up on -a. So it was incorrect to show in Deck that they might be placed on -a.
Closes spinnaker/spinnaker#4071