Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" #6808

Merged
1 commit merged into from Apr 3, 2019
Merged

fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" #6808

1 commit merged into from Apr 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2019 •
edited by ghost
Loading

This reverts commit ad2e222.

In hindsight, Deck was already doing the right thing here. The platform, GCP, chooses the zones if the user doesn't specify them. In some quick testing through the GCP UI, MIGs in us-central1 always seem to get spread across zones -b, -c, and -f and never end up on -a. So it was incorrect to show in Deck that they might be placed on -a.

Closes spinnaker/spinnaker#4071

@ghost ghost requested review from louisjimenez and maggieneterval April 3, 2019 12:36
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

fix(google): revert "select all zones by default when deploying a reg…
1799e78 
…ional gce server group (#6751)"

This reverts commit ad2e222.

In hindsight, Deck was already doing the right thing here. GCP chooses
the zones and, in some quick testing, the MIGs in us-central1 always
seem to get spread across zones -b, -c, and -f.
@ghost ghost changed the title Revert "fix(google): select all zones by default when deploying a regional gce server group" fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" Apr 3, 2019
@ghost ghost merged commit 728ddbe into spinnaker:master Apr 3, 2019
@ghost ghost deleted the revert-gce-zone-spread branch April 3, 2019 14:07
@ghost
Copy link
Author

ghost commented Apr 3, 2019

@spinnakerbot cherry-pick 1.12

@ghost
Copy link
Author

ghost commented Apr 3, 2019

@spinnakerbot cherry-pick 1.13

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 728ddbe) with exit code 1:

error: could not apply 728ddbe0d... fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

spinnakerbot pushed a commit that referenced this pull request Apr 3, 2019
fix(google): revert "select all zones by default when deploying a reg…
ee137c0 
…ional gce server group (#6751)" (#6808)

This reverts commit ad2e222.

In hindsight, Deck was already doing the right thing here. GCP chooses
the zones and, in some quick testing, the MIGs in us-central1 always
seem to get spread across zones -b, -c, and -f.
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #6809

@ghost ghost mentioned this pull request Apr 3, 2019
Merged
ghost pushed a commit that referenced this pull request Apr 3, 2019
@spinnakerbot
fix(google): revert "select all zones by default when deploying a reg…
4014e4c 
…ional gce server group (#6751)" (#6808) (#6809)

This reverts commit ad2e222.

In hindsight, Deck was already doing the right thing here. GCP chooses
the zones and, in some quick testing, the MIGs in us-central1 always
seem to get spread across zones -b, -c, and -f.
kevinawoo pushed a commit to armory-io/deck that referenced this pull request Apr 5, 2019
@kevinawoo
fix(google): revert "select all zones by default when deploying a reg…
c836603 
…ional gce server group (spinnaker#6751)" (spinnaker#6808)

This reverts commit ad2e222.

In hindsight, Deck was already doing the right thing here. GCP chooses
the zones and, in some quick testing, the MIGs in us-central1 always
seem to get spread across zones -b, -c, and -f.
kevinawoo added a commit to armory-io/deck that referenced this pull request Apr 8, 2019
@kevinawoo
Merge branch 'master' into feature/display-lots-of-parameters
e9cb1d0 
* master: (28 commits)
  feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816)
  feat(cf): Create Service Key pipeline stage (spinnaker#6821)
  feat(core): Create pipeline from v2 template list
  fix(provider/cf): Clone model so Orca monitors the correct foundation for up instances (spinnaker#6817)
  chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820)
  fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (spinnaker#6818)
  feat(provider/azure): Add redblack strategy for azure (spinnaker#6801)
  fix(mptv2): clicking a view link on template list screen throws exception (spinnaker#6815)
  fix(artifacts): helm artifact, replace object assignw with object spread (spinnaker#6814)
  fix(provider/cf): Fix provider selection for resize stage in pipeline (spinnaker#6754)
  fix(artifacts): default helm artifact editor is broken (spinnaker#6811)
  fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808)
  fix(google): GCE create server group and load balancer fixes (spinnaker#6806)
  Bump package core to 0.0.350 and amazon to 0.0.184 (spinnaker#6807)
  fix(amazon): hide security groups on NLBs (spinnaker#6803)
  refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802)
  fix(google): fix autohealing health checks in deploy stages (spinnaker#6804)
  fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794)
  fix(triggers): Add lastSuccessfulBuild as a build option in Jenkins default artifact (spinnaker#6797)
  fix(provider/cf): Make expected artifacts selectable as clone manifests (spinnaker#6796)
  ...
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
@christopherthielen
chore(google): Bump version to 0.0.6
7ed79c6 
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (spinnaker#6929)
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861)
297cd99 feat(provider/google): Support Shielded VM policies (spinnaker#6849)
728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808)
bdcbc97 fix(google): GCE create server group and load balancer fixes (spinnaker#6806)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802)
0daec5b fix(google): fix autohealing health checks in deploy stages (spinnaker#6804)
ad2e222 fix(google): select all zones by default when deploying a regional gce server group (spinnaker#6751)
432e6e3 fix(google): add better help text around accelerators (spinnaker#6750)
eb7f661 feat(provider/gce): Moniker support for GCE server groups (spinnaker#6317)
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
f0f4c0d fix(google): Only show authorized accounts during Server group creation (spinnaker#6625)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599)
64fb489 fix(html): Fix various invalid HTML (spinnaker#6597)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (spinnaker#6569)
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
@christopherthielen christopherthielen mentioned this pull request Jun 5, 2019
Merged
christopherthielen added a commit that referenced this pull request Jun 5, 2019
@christopherthielen
chore(google): Bump version to 0.0.6
fc7645a 
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (#6929)
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861)
297cd99 feat(provider/google): Support Shielded VM policies (#6849)
728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808)
bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802)
0daec5b fix(google): fix autohealing health checks in deploy stages (#6804)
ad2e222 fix(google): select all zones by default when deploying a regional gce server group (#6751)
432e6e3 fix(google): add better help text around accelerators (#6750)
eb7f661 feat(provider/gce): Moniker support for GCE server groups (#6317)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
f0f4c0d fix(google): Only show authorized accounts during Server group creation (#6625)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
04bb4a0 fix(html): Fix various invalid HTML (#6599)
64fb489 fix(html): Fix various invalid HTML (#6597)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569)
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target-release/1.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spinnakerbot @louisjimenez @maggieneterval