fix(html): Fix various invalid HTML #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcomstock
approved these changes
Feb 21, 2019
gcomstock
approved these changes
Feb 21, 2019
app/scripts/modules/core/src/notification/notificationList.directive.html
Outdated
Show resolved
Hide resolved
christopherthielen
force-pushed
the
fix-broken-html
branch
from
363f93c
to
f9f5a13
Compare
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 39f6858 fix(core/diffs): Fix misnamed tempate field 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 14bf52b feat(gremlin): Per feedback review within gate, change the Gate gremlin endpoint prefix from "gremlin" to "integrations/gremlin" (spinnaker#6591)
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597)
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
christopherthielen
added a commit
that referenced
this pull request
Feb 22, 2019
7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 64fb489 fix(html): Fix various invalid HTML (#6597) 39f6858 fix(core/diffs): Fix misnamed tempate field 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) 14bf52b feat(gremlin): Per feedback review within gate, change the Gate gremlin endpoint prefix from "gremlin" to "integrations/gremlin" (#6591)
christopherthielen
added a commit
that referenced
this pull request
Feb 22, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (spinnaker#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861) 297cd99 feat(provider/google): Support Shielded VM policies (spinnaker#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (spinnaker#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (spinnaker#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (spinnaker#6751) 432e6e3 fix(google): add better help text around accelerators (spinnaker#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (spinnaker#6317) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (spinnaker#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 64fb489 fix(html): Fix various invalid HTML (spinnaker#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (spinnaker#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (#6929) 0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861) 297cd99 feat(provider/google): Support Shielded VM policies (#6849) 728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808) bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) 0daec5b fix(google): fix autohealing health checks in deploy stages (#6804) ad2e222 fix(google): select all zones by default when deploying a regional gce server group (#6751) 432e6e3 fix(google): add better help text around accelerators (#6750) eb7f661 feat(provider/gce): Moniker support for GCE server groups (#6317) e2b4d8e refactor(*): remove unused local storage caches (#6665) f0f4c0d fix(google): Only show authorized accounts during Server group creation (#6625) d828a53 chore(angularjs): Explicitly annotate directive controllers 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 64fb489 fix(html): Fix various invalid HTML (#6597) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569) ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier now supports HTML. It told me these things are invalid HTML.