fix(html): Fix various invalid HTML (#6597)

spinnaker · Feb 21, 2019 · 64fb489 · 64fb489
1 parent 39f6858
commit 64fb489
Show file tree

Hide file tree

Showing 21 changed files with 9 additions and 34 deletions.
diff --git a/app/scripts/modules/amazon/src/pipeline/stages/bake/bakeStage.html b/app/scripts/modules/amazon/src/pipeline/stages/bake/bakeStage.html
@@ -43,7 +43,6 @@
         <label>
           <input type="checkbox"
                  ng-model="stage.rebake">
-          </input>
           Rebake image without regard to the status of any existing bake
         </label>
       </div>

diff --git a/app/scripts/modules/azure/pipeline/stages/bake/bakeStage.html b/app/scripts/modules/azure/pipeline/stages/bake/bakeStage.html
@@ -27,7 +27,6 @@
         <label>
           <input type="checkbox"
                  ng-model="stage.rebake">
-          </input>
           Rebake image without regard to the status of any existing bake
         </label>
       </div>

diff --git a/app/scripts/modules/core/src/notification/notificationList.directive.html b/app/scripts/modules/core/src/notification/notificationList.directive.html
@@ -62,8 +62,8 @@
     <div class="col-md-9 text-right">
         <button class="btn btn-primary ng-scope" ng-if="notificationListCtrl.isNotificationsDirty"
                 ng-click="notificationListCtrl.saveNotifications()">
-            <span class="far fa-check-circle"></span> Save Changes
-            </span></button>
+            <span class="far fa-check-circle"> Save Changes </span>
+        </button>
         <span ng-if="notificationListCtrl.isNotificationsDirty === false" class="btn btn-link disabled ng-scope"><span class="far fa-check-circle"></span> In sync with server</span>
     </div>
 </div>
diff --git a/app/scripts/modules/core/src/notification/types/bearychat/additionalFields.html b/app/scripts/modules/core/src/notification/types/bearychat/additionalFields.html
@@ -8,7 +8,6 @@
              ng-model="vm.notification.address"
              placeholder="enter an email address"
              ng-required="!vm.notification.cc.length">
-      </input>
     </div>
   </div>
   <div class="form-group row slide-in"

diff --git a/app/scripts/modules/core/src/notification/types/email/additionalFields.html b/app/scripts/modules/core/src/notification/types/email/additionalFields.html
@@ -8,7 +8,6 @@
              ng-model="vm.notification.address"
              placeholder="enter an email address"
              ng-required="!vm.notification.cc.length">
-      </input>
     </div>
   </div>
   <div class="form-group row slide-in"
@@ -26,7 +25,6 @@
              ng-model="vm.notification.cc"
              placeholder="enter an email address"
              ng-required="!vm.notification.address.length">
-      </input>
     </div>
   </div>
   <div class="form-group row slide-in"

diff --git a/app/scripts/modules/core/src/notification/types/googlechat/additionalFields.html b/app/scripts/modules/core/src/notification/types/googlechat/additionalFields.html
@@ -7,6 +7,5 @@
            ng-model="vm.notification.address"
            placeholder="URL starts with https://chat.googleapis.com/v1/spaces/"
            required />
-    </input>
   </div>
 </div>
diff --git a/app/scripts/modules/core/src/notification/types/pubsub/additionalFields.html b/app/scripts/modules/core/src/notification/types/pubsub/additionalFields.html
@@ -8,7 +8,6 @@
              ng-model="vm.notification.publisherName"
              placeholder="enter a pubsub publisher name"
              ng-required="!vm.notification.publisherName.length">
-      </input>
     </div>
   </div>
   <div class="form-group row slide-in"

diff --git a/...ts/modules/core/src/pipeline/config/preconditions/types/clusterSize/additionalFields.html b/...ts/modules/core/src/pipeline/config/preconditions/types/clusterSize/additionalFields.html
@@ -50,7 +50,6 @@
              class="form-control input-sm "
              ng-model="precondition.context.expected"
              required>
-      </input>
     </div>
   </div>
 

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/bake/modal/addExtendedAttribute.html b/app/scripts/modules/core/src/pipeline/config/stages/bake/modal/addExtendedAttribute.html
@@ -14,7 +14,6 @@ <h3 data-purpose="modal-header">Add Extended Attribute</h3>
                  ng-model="extendedAttribute.key"
                  placeholder="enter an attribute key"
                  required>
-          </input>
         </div>
       </div>
       <div class="form-group row">

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/bakeManifestConfig.html b/app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/bakeManifestConfig.html
@@ -17,12 +17,10 @@ <h4>Template Renderer</h4>
              ng-change="ctrl.outputNameChange()"
              ng-class="{'ng-invalid': !ctrl.$scope.stage.outputName}"
              >
-      </input>
     </stage-config-field>
     <stage-config-field label="Namespace" field-columns="3">
       <input type="text" class="form-control input-sm"
              ng-model="ctrl.$scope.stage.namespace">
-      </input>
     </stage-config-field>
 
     <h4>Template Artifact</h4>

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/pipeline/pipelineStage.html b/app/scripts/modules/core/src/pipeline/config/stages/pipeline/pipelineStage.html
@@ -59,7 +59,6 @@ <h4 class="text-left">Pipeline Parameters</h4>
                  ng-change="pipelineStageCtrl.updateParam(parameter.name)">Use default
         </label>
       </div>
-      </ng-if>
     </div>
   </div>
   <stage-config-field label="Wait for results" help-key="pipeline.waitForCompletion">

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/travis/modal/addParameter.html b/app/scripts/modules/core/src/pipeline/config/stages/travis/modal/addParameter.html
@@ -14,7 +14,6 @@ <h3 data-purpose="modal-header">Add Parameter</h3>
                  ng-model="parameter.key"
                  placeholder="enter a parameter key"
                  required>
-          </input>
         </div>
       </div>
       <div class="form-group row">
@@ -25,7 +24,6 @@ <h3 data-purpose="modal-header">Add Parameter</h3>
                  ng-model="parameter.value"
                  placeholder="enter a parameter value"
                  required>
-          </input>
         </div>
       </div>
     </div>

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/webhook/modal/addCustomHeader.html b/app/scripts/modules/core/src/pipeline/config/stages/webhook/modal/addCustomHeader.html
@@ -14,7 +14,6 @@ <h3 data-purpose="modal-header">Add Custom Header</h3>
                  ng-model="customHeader.key"
                  placeholder="enter a header key"
                  required>
-          </input>
         </div>
       </div>
       <div class="form-group row">
@@ -25,7 +24,6 @@ <h3 data-purpose="modal-header">Add Custom Header</h3>
                  ng-model="customHeader.value"
                  placeholder="enter a header value"
                  required>
-          </input>
         </div>
       </div>
     </div>

diff --git a/app/scripts/modules/core/src/pipeline/config/stages/wercker/modal/addParameter.html b/app/scripts/modules/core/src/pipeline/config/stages/wercker/modal/addParameter.html
@@ -14,7 +14,6 @@ <h3 data-purpose="modal-header">Add Parameter</h3>
                  ng-model="parameter.key"
                  placeholder="enter a parameter key"
                  required>
-          </input>
         </div>
       </div>
       <div class="form-group row">
@@ -25,7 +24,6 @@ <h3 data-purpose="modal-header">Add Parameter</h3>
                  ng-model="parameter.value"
                  placeholder="enter a parameter value"
                  required>
-          </input>
         </div>
       </div>
     </div>

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/pipeline/pipelineTrigger.html b/app/scripts/modules/core/src/pipeline/config/triggers/pipeline/pipelineTrigger.html
@@ -47,7 +47,6 @@ <h4 class="text-left">Pipeline Parameters</h4>
                    ng-change="pipelineTriggerCtrl.updateParam(parameter.name)">Use default
           </label>
         </div>
-        </ng-if>
       </div>
     </div>
   <div class="form-group">

diff --git a/app/scripts/modules/core/src/projects/dashboard/cluster/projectCluster.directive.html b/app/scripts/modules/core/src/projects/dashboard/cluster/projectCluster.directive.html
@@ -74,7 +74,6 @@
             <span ng-if="application.regions[region].inconsistentBuilds.length">
               <i class="fa fa-exclamation-triangle"
                  uib-tooltip-template="vm.inconsistentBuildsTemplate"></i>
-              </span>
             </span>
           </span>
           <span ng-if="!application.regions[region]">

diff --git a/app/scripts/modules/core/src/serverGroup/details/scalingActivities/scalingActivities.html b/app/scripts/modules/core/src/serverGroup/details/scalingActivities/scalingActivities.html
@@ -19,14 +19,13 @@ <h3>Scaling Activities for {{$ctrl.serverGroup.name}}</h3>
           <span class="label label-default pull-right">{{activity.startTime | timestamp}}</span>
         </p>
         <p>{{activity.cause}}</p>
-        <p>Summary of activities:
-          <ul>
-            <li ng-repeat="event in activity.events | orderBy: ['availabilityZone', 'description']">
-              {{event.description}}
-              <span ng-if="event.availabilityZone"> ({{event.availabilityZone}})</span>
-            </li>
-          </ul>
-        </p>
+        <p>Summary of activities:</p>
+        <ul>
+          <li ng-repeat="event in activity.events | orderBy: ['availabilityZone', 'description']">
+            {{event.description}}
+            <span ng-if="event.availabilityZone"> ({{event.availabilityZone}})</span>
+          </li>
+        </ul>
         <hr ng-if="!$last"/>
     </div>
   </div>

diff --git a/app/scripts/modules/core/src/task/tasks.html b/app/scripts/modules/core/src/task/tasks.html
@@ -62,7 +62,6 @@ <h4>
           <p style="margin-top: 20px">
             <strong>Note</strong> that Spinnaker only tracks tasks for two weeks.
           </p>
-        </p>
         </div>
       </div>
       <div class="col-md-12" ng-if="tasks.sortedTasks.length">

diff --git a/app/scripts/modules/docker/src/pipeline/stages/bake/bakeStage.html b/app/scripts/modules/docker/src/pipeline/stages/bake/bakeStage.html
@@ -32,7 +32,6 @@
         <label>
           <input type="checkbox"
                  ng-model="stage.rebake">
-          </input>
           Rebake image without regard to the status of any existing bake
         </label>
       </div>

diff --git a/app/scripts/modules/google/src/pipeline/stages/bake/bakeStage.html b/app/scripts/modules/google/src/pipeline/stages/bake/bakeStage.html
@@ -34,7 +34,6 @@
       <label>
         <input type="checkbox"
                ng-model="stage.rebake">
-        </input>
         Rebake image without regard to the status of any existing bake
       </label>
     </div>

diff --git a/app/scripts/modules/openstack/src/pipeline/stages/bake/bakeStage.html b/app/scripts/modules/openstack/src/pipeline/stages/bake/bakeStage.html
@@ -28,7 +28,6 @@
         <label>
           <input type="checkbox"
                  ng-model="stage.rebake">
-          </input>
           Rebake image without regard to the status of any existing bake
         </label>
       </div>