fix(mptv2): clicking a view link on template list screen throws exception #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
louisjimenez
approved these changes
Apr 4, 2019
kevinawoo
pushed a commit
to armory-io/deck
that referenced
this pull request
Apr 5, 2019
kevinawoo
added a commit
to armory-io/deck
that referenced
this pull request
Apr 8, 2019
* master: (28 commits) feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816) feat(cf): Create Service Key pipeline stage (spinnaker#6821) feat(core): Create pipeline from v2 template list fix(provider/cf): Clone model so Orca monitors the correct foundation for up instances (spinnaker#6817) chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820) fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (spinnaker#6818) feat(provider/azure): Add redblack strategy for azure (spinnaker#6801) fix(mptv2): clicking a view link on template list screen throws exception (spinnaker#6815) fix(artifacts): helm artifact, replace object assignw with object spread (spinnaker#6814) fix(provider/cf): Fix provider selection for resize stage in pipeline (spinnaker#6754) fix(artifacts): default helm artifact editor is broken (spinnaker#6811) fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808) fix(google): GCE create server group and load balancer fixes (spinnaker#6806) Bump package core to 0.0.350 and amazon to 0.0.184 (spinnaker#6807) fix(amazon): hide security groups on NLBs (spinnaker#6803) refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) fix(google): fix autohealing health checks in deploy stages (spinnaker#6804) fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794) fix(triggers): Add lastSuccessfulBuild as a build option in Jenkins default artifact (spinnaker#6797) fix(provider/cf): Make expected artifacts selectable as clone manifests (spinnaker#6796) ...
anotherchrisberry
added a commit
that referenced
this pull request
Apr 16, 2019
…85 and titus to 0.0.87 (#6855) * chore(core): Bump version to 0.0.351 f6c87a3 refactor(core/amazon): allow custom load balancer creation flow (#6852) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795) 20d6766 feat(help): Custom help link (#6842) a9cfe57 chore: upgrade to react 16.8 (#6846) 2e4135a fix(pipeline/executionStatus): "details" link hidden by scrollbar. (#6850) af8fa5f feat(preconfiguredJobs): support produce artifacts (#6845) 48ba3fc fix(core/pipeline): un-shadow parameter (#6843) ec12527 feat(core/pipeline): add execution UI for waitForCondition stage (#6826) e17f387 fix(artifacts): HTTP default artifact needs reference field (#6836) e618548 feat(preconfiguredJob): logs for k8s jobs (#6840) 6072ee5 feat(core/pipelineConfig): toggle pins individually (#6830) c25363c fix(artifacts): Clean pipeline expected artifacts when triggers are removed (#6799) 5640431 fix(k8s): Fix deploy manifest (#6833) 2020bf6 feat(core/execution-parameters): condense parameters/artifacts and make it collapsable (#6756) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (#6816) bcca9dc feat(core): Create pipeline from v2 template list d7e860c fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (#6818) 1201896 fix(mptv2): clicking a view link on template list screen throws exception (#6815) 985a3ad fix(artifacts): helm artifact, replace object assignw with object spread (#6814) 2039b34 fix(artifacts): default helm artifact editor is broken (#6811) bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806) * chore(docker): Bump version to 0.0.36 d7e860c fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (#6818) * chore(amazon): Bump version to 0.0.185 f6c87a3 refactor(core/amazon): allow custom load balancer creation flow (#6852) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795) * chore(titus): Bump version to 0.0.87 30556ad fix(titus): send serverGroupName when terminating instances (#6854) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewTemplateIdshould betemplateIdwhen it's a parameter passed to the pipeline-templates-detail route.