chore: upgrade to react 16.8 #6846
Conversation
maggieneterval
requested review from
christopherthielen,
anotherchrisberry,
erikmunson,
a user,
louisjimenez and
jkschneider
|
Nice! 👏
I think having a looser range to at least include patches could be helpful but perhaps there is some historical context /background to using pinned versions? |
I had pinned it because it looks like that's what's been done in the past but I'll leave the call up to @christopherthielen 😄 |
Yes, I'd actually prefer semver range |
|
Any reason not to upgrade the |
|
Sorry @maggieneterval, I pushed the wrong button and did not mean to close this. |
maggieneterval
force-pushed
the
react-upgrade
branch
from
d94412c
to
4bea1e7
Compare
maggieneterval
force-pushed
the
react-upgrade
branch
from
4bea1e7
to
6199f2b
Compare
|
Updated react, react-dom, types/react, and types/react-dom all to ~16.8.0. Re-ran tests and clicked around a bit and all seems to be well! |
…85 and titus to 0.0.87 (#6855) * chore(core): Bump version to 0.0.351 f6c87a3 refactor(core/amazon): allow custom load balancer creation flow (#6852) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795) 20d6766 feat(help): Custom help link (#6842) a9cfe57 chore: upgrade to react 16.8 (#6846) 2e4135a fix(pipeline/executionStatus): "details" link hidden by scrollbar. (#6850) af8fa5f feat(preconfiguredJobs): support produce artifacts (#6845) 48ba3fc fix(core/pipeline): un-shadow parameter (#6843) ec12527 feat(core/pipeline): add execution UI for waitForCondition stage (#6826) e17f387 fix(artifacts): HTTP default artifact needs reference field (#6836) e618548 feat(preconfiguredJob): logs for k8s jobs (#6840) 6072ee5 feat(core/pipelineConfig): toggle pins individually (#6830) c25363c fix(artifacts): Clean pipeline expected artifacts when triggers are removed (#6799) 5640431 fix(k8s): Fix deploy manifest (#6833) 2020bf6 feat(core/execution-parameters): condense parameters/artifacts and make it collapsable (#6756) 2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (#6816) bcca9dc feat(core): Create pipeline from v2 template list d7e860c fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (#6818) 1201896 fix(mptv2): clicking a view link on template list screen throws exception (#6815) 985a3ad fix(artifacts): helm artifact, replace object assignw with object spread (#6814) 2039b34 fix(artifacts): default helm artifact editor is broken (#6811) bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806) * chore(docker): Bump version to 0.0.36 d7e860c fix(triggers): Remove RunAsUser if pipeline permissions enabled for react triggers. (#6818) * chore(amazon): Bump version to 0.0.185 f6c87a3 refactor(core/amazon): allow custom load balancer creation flow (#6852) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795) * chore(titus): Bump version to 0.0.87 30556ad fix(titus): send serverGroupName when terminating instances (#6854) 6ddc476 fix(titus): correctly set dirty field on command viewstate (#6795)
reactfrom 16.6.0 to ~16.8.0.react-domfrom 16.6.0 to ~16.8.0.@types/reactfrom ^16.4.18 to ~16.8.0@types/react-domfrom 16.0.5 to ~16.8.0.@types/reactupgrade inOverridable.tsx:Conversion of type 'ForwardRefExoticComponent<PropsWithoutRef<P> & RefAttributes<{}>>' to type 'T' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.I just did exactly what the error told me to do to fix this, but more creative solutions are welcome.