-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs): Remove unused cacheInitializer injection #6681
Merged
anotherchrisberry
merged 1 commit into
spinnaker:master
from
clareliguori:fix-ecs-injections
Mar 13, 2019
Merged
fix(ecs): Remove unused cacheInitializer injection #6681
anotherchrisberry
merged 1 commit into
spinnaker:master
from
clareliguori:fix-ecs-injections
Mar 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry about that! |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) 1c61cb2 feat(ecs): service discovery configuration (spinnaker#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (spinnaker#6906) c550d82 feat(ecs): Configure tags (spinnaker#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (spinnaker#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (spinnaker#6746) 1c9e075 feat(ecs): docker image selection (spinnaker#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (spinnaker#6681) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (spinnaker#6251) e802c45 fix(*): allow modal to stay open on auto-close (spinnaker#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (spinnaker#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (spinnaker#5799)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) 1c61cb2 feat(ecs): service discovery configuration (#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (#6906) c550d82 feat(ecs): Configure tags (#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (#6746) 1c9e075 feat(ecs): docker image selection (#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (#6681) e2b4d8e refactor(*): remove unused local storage caches (#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (#6251) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (#5799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ECS server group modal. Currently it won't load because the $inject list and the constructor list don't match up, leading to the wrong types being injected.