fix(*): allow modal to stay open on auto-close #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherchrisberry
added a commit
that referenced
this pull request
Jan 10, 2019
…50 and titus to 0.0.66 (#6343) * chore(core): Bump version to 0.0.309 aefc576 fix(docker): Do not clear an existing imageId even if fields cannot be found in registry (#6342) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 33e2e5b fix(core): do not flag pipelines dirty on initial save (#6340) 94b1e9f feat(core): allow searching in pipeline JSON (#6341) * chore(docker): Bump version to 0.0.29 aefc576 fix(docker): Do not clear an existing imageId even if fields cannot be found in registry (#6342) * chore(amazon): Bump version to 0.0.150 e802c45 fix(*): allow modal to stay open on auto-close (#6329) * chore(titus): Bump version to 0.0.66 e802c45 fix(*): allow modal to stay open on auto-close (#6329)
anotherchrisberry
added a commit
that referenced
this pull request
Feb 13, 2019
* chore(kubernetes): Bump version to 0.0.21 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ 9eccc0f refactor(artifacts): Generalize artifact delegate for reuse (#6495) 6c54b61 fix(kubernetes): do not override `location` and `replicas` in new Scale Manifest stage a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 54157f2 fix(kubernetes/serverGroup): Remove module.exports assignment in typescript file 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d53836b refactor(kubernetes/modal): Refactor kubernetes modals to use WizardPage component dba26d8 feat(kubernetes/v2): Converts CopyToClipboard to React Component (#6451) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 65c2601 fix(kubernetes): post strategic patch body as object 51a8542 fix(kubernetes): fix account selection by handling null values passed to ManifestSelector.isExpression 35be1f0 refactor(*): Don't use js or ts file extension in require() a02a5e1 chore(k8s): clean up imports (#6430) fa18bdc feat(kubernetes/v2): Adds CopyToClipboard component to ease getting text from UI (#6419) 98a85e9 chore(*): bump @types/enzyme@3.1.15, @types/jasmine@3.3.7, enzyme@3.8.0, enzyme-adapter-react-16@1.7.1, karma@4.0.0, karma-jasmine@2.0.1, karma-webpack@3.0.5, typescript@^3.2.4, jasmine-core@3.3.0 - disable jasmine 3.0's random test order by default feature 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 6fee54d fix(kubernetes): specify monospace fonts to prevent cursor misalignment in ace editor 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) * chore(google): Bump version to 0.0.5 a8c1749 chore(package): Just Update Prettier™ a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d09a910 feat(google): Add support for accelerators when deploying VMs (#6467) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 87013c6 config(google): Update GCE's base URL to the new domain (#6401) 9f90ebd fix(google): safe healthcheck lookups when cloning server group b920442 fix(google): differentiate among autohealing health check kinds 786862b fix(google): fix autohealing clone logic 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) d4127fa fix(google): prevent parent server group from overwriting null clone autohealing policies 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 3afbd00 fix(bake): Allow null extended attributes in bake stages (#6256) 6b8188b chore(*): Add core alias to module tsconfigs
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) 1c61cb2 feat(ecs): service discovery configuration (spinnaker#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (spinnaker#6906) c550d82 feat(ecs): Configure tags (spinnaker#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (spinnaker#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (spinnaker#6746) 1c9e075 feat(ecs): docker image selection (spinnaker#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (spinnaker#6681) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (spinnaker#6251) e802c45 fix(*): allow modal to stay open on auto-close (spinnaker#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (spinnaker#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (spinnaker#5799)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) 1c61cb2 feat(ecs): service discovery configuration (#6899) 654fd3a feat(ecs): Configuration for platform version & placement constraints (#6906) c550d82 feat(ecs): Configure tags (#6905) 269d005 fix(ecs): populate load balancers when configuring cmd (#6778) 6a76b5f fix(ecs): Fix name of health check grace period attribute (#6746) 1c9e075 feat(ecs): docker image selection (#6687) d63dc6d fix(ecs): Remove unused cacheInitializer injection (#6681) e2b4d8e refactor(*): remove unused local storage caches (#6665) 2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 04bb4a0 fix(html): Fix various invalid HTML (#6599) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 56ce321 feat(ecs): Add option to copy scaling policies from previous server group (#6251) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 5d0d72a fix(provider/ecs): Add memory limit to server group details (#6135) 6b8188b chore(*): Add core alias to module tsconfigs 190064f feat(ecs): support private registry credentials (#5799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a details panel's data cannot be found, we typically automatically close the panel, rather than displaying a message that the item cannot be found.
This is fine, but we also do a thing where we close all modals when the state changes. Normally, this is no problem. However, when these panels auto-close, it can be frustrating, especially if you happened to have an instance details panel open and you were creating a new server group, because that modal would close on you.
The solution we used to have was that we'd set an arbitrary flag
allowModalToStayOpenon the current state params. We came up with this approach over three years ago, and I'm guessing it was a sneaky hack then. Something was changed (fixed?) in ui-router that made the$state.params.allowModalToStayOpen = truecalls not change thefromParamsbeing passed to the$stateChangeSuccessevent. It's probably good it's doing that because it's weird that you could arbitrarily modify those parameters outside a routing event.This approach is a little cleaner, I think. Also it works.