feat(core): allow searching in pipeline JSON #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally think that having a second, not as familiar search box is almost always a bad pattern for things that are just text (I'm looking at you Bitbucket). That said, if this is how you wanna play it then go for it 😄 |
|
@erikmunson I agree; however, the entire JSON blob is not rendered by the editor, so, if we disable the find command on the editor, we're only able to search the visible contents of the JSON. The find box looks pretty familiar, IMO: |
|
I was hoping you weren't going to say they virtualized it 😢 carry on... |
anotherchrisberry
added a commit
that referenced
this pull request
Jan 10, 2019
…50 and titus to 0.0.66 (#6343) * chore(core): Bump version to 0.0.309 aefc576 fix(docker): Do not clear an existing imageId even if fields cannot be found in registry (#6342) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 33e2e5b fix(core): do not flag pipelines dirty on initial save (#6340) 94b1e9f feat(core): allow searching in pipeline JSON (#6341) * chore(docker): Bump version to 0.0.29 aefc576 fix(docker): Do not clear an existing imageId even if fields cannot be found in registry (#6342) * chore(amazon): Bump version to 0.0.150 e802c45 fix(*): allow modal to stay open on auto-close (#6329) * chore(titus): Bump version to 0.0.66 e802c45 fix(*): allow modal to stay open on auto-close (#6329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
cmd+fdoesn't do anything.With this, you get a pretty nice search box within the editor.