-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Surface invalid params for a pipeline stage #6668
Conversation
@@ -12,7 +12,7 @@ | |||
} | |||
|
|||
.artifact-select .Select-arrow-zone { | |||
border-left: 1px solid rgb(204, 204, 204); | |||
border-left: 1px solid var(--color-alto); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbwsg This gets rid of the lint warning. Hope this ok. (They are the same color)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice. can we do the same for the jenkins stage?
yup, upcoming. |
#6672) * chore(core): Bump version to 0.0.343 eacfe75 feat(core): Warning message about invalid job params (#6669) a28f7af fix(core): Surface invalid params for a pipeline stage (#6668) e2b4d8e refactor(*): remove unused local storage caches (#6665) 35e82ac feat(core): Add support for an Artifactory Trigger (#6664) bc2bf43 feat(jenkins): Add artifact status tab to Jenkins execution details (#6666) e0bda86 feat(artifacts): Re-use artifacts when re-running a pipeline (#6663) 29582dd feat(core): Filter v2 pipeline templates from create pipeline modal (#6660) 45678a1 fix(core/pipeline): make cancelmodal take markdown for body (#6662) 02af17f fix(artifacts): Correct render-if-feature for new artifacts on stage 'produces artifact' (#6661) 0eb634c fix(artifacts): Maven/ivy reference field, Base64 validation, SpelText performance (#6656) 93e89be fix(core): Remove ability to trigger manual exec for mptv2 pipelines (#6651) d3209d4 feat(core): Add pipeline to IStageConfigProps (#6655) 1bc94a1 chore(angularjs): explicitly annotate more angularjs injections (#6653) 78d0aae fix(artifacts): save HTTP URL as artifact reference (#6650) 09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645) 8e9cb0b fix(core): titus run jobs override all other providers (#6647) 12e3bff fix(core): Remove configure button and setup redirect for mptv2 pipeline (#6644) 5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634) eae6b45 feat(users): Always surface authenticated user for executions/tasks (#6638) * chore(amazon): Bump version to 0.0.179 e2b4d8e refactor(*): remove unused local storage caches (#6665) 09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645) * chore(titus): Bump version to 0.0.79 e2b4d8e refactor(*): remove unused local storage caches (#6665)
Parameters not accepted by a pipeline are highlighted in a pipeline stage.
The stage config can end up having parameters that are no longer needed/accepted by the pipeline stage. Having them around might lead to issues during executions and silently too. This difff adds a message with all params that the stage is going to pass to the pipeline that are not accepted by the pipeline execution. It also removes them all if the user chooses to. Image attached below.