Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TapThrough Functionality for TabBarController #118

Open
acali18 opened this issue Nov 8, 2019 · 4 comments
Open

TapThrough Functionality for TabBarController #118

acali18 opened this issue Nov 8, 2019 · 4 comments

Comments

@acali18
Copy link

acali18 commented Nov 8, 2019

I am having a problem with the tapThrough functionality of the tabBar. Allowing tapThrough on a tabBar creates the following error:
"Directly modifying a tab bar managed by a tab bar controller is not allowed'

Here is the code I've used in the past to select a tabBar index:
self.tabBarController?.selectedIndex = 2

But here is the code in the MaterialShowcase.swift:
onTapThrough = { tabBar.selectedItem = tabBar.items?[itemIndex] }

I believe I need to pass the tabBarController and will need a new constructor to do so as discussed here: #112 (comment)

@petrkahanek
Copy link

Hello,

any news to this? Checked #112 and seems that it is not fixed yet. Or would you recommend any workaround?

@imSarfaroz
Copy link

Any updates?

@Husseinhj
Copy link
Contributor

Any updates?
@imSarfaroz

Created #158 pull request to support TabBarViewController.

@petrkahanek
Copy link

petrkahanek commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants