Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TapThrough Functionality #112

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Conversation

poisondminds
Copy link

Let me know if this needs more explanation.

Also, I did make changes to the sample app on my local machine to test this out, but didn't necessarily want to include them. Let me know if you'd want to see how I tested, or if you have trouble testing yourself.

@poisondminds poisondminds mentioned this pull request Oct 4, 2019
@quangctkm9207 quangctkm9207 merged commit dacac99 into aromajoin:master Oct 5, 2019
@quangctkm9207
Copy link
Collaborator

Thank @poisondminds! I merged it already.

@poisondminds poisondminds deleted the tapthrough branch October 5, 2019 23:08
@GPryan
Copy link
Contributor

GPryan commented Oct 7, 2019

Great! @quangctkm9207 would you consider making a 0.6.7 including some of the recent changes?

@quangctkm9207
Copy link
Collaborator

Sure @GPryan . I'm gonna release it today.

@poisondminds
Copy link
Author

Great :) I look forward do it

@quangctkm9207
Copy link
Collaborator

I have just published the version '0.7.0' on CocoaPods. You can check it out.

@acali18
Copy link

acali18 commented Nov 5, 2019

I am having a problem with the tapThrough functionality of the tabBar. Allowing tapThrough on a tabBar creates the following error:
"Directly modifying a tab bar managed by a tab bar controller is not allowed'

Here is the code I've used in the past to select a tabBar index:
self.tabBarController?.selectedIndex = 2

But here is the code in the MaterialShowcase.swift:
onTapThrough = { tabBar.selectedItem = tabBar.items?[itemIndex] }

I believe I need to pass the tabBarController somehow?

@poisondminds
Copy link
Author

@acali18 Ah yes, it's looking like this functionality is only working properly for standalone UITabBar and not with a tab bar controller. Can you make another issue for this? It's likely that we'll have to supply another constructor that accepts a UITabBarController

@acali18
Copy link

acali18 commented Nov 8, 2019

@poisondminds - Yes, that sounds correct. I will make the new issue. I wanted to discuss it first in case I had missed something.

@acali18
Copy link

acali18 commented Nov 8, 2019

Created here: #118

@petrkahanek
Copy link

Hello guys,

any news to this? I am having the same issue as @acali18 .

@imSarfaroz
Copy link

Any updates guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants