-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TapThrough Functionality #112
Conversation
Thank @poisondminds! I merged it already. |
Great! @quangctkm9207 would you consider making a 0.6.7 including some of the recent changes? |
Sure @GPryan . I'm gonna release it today. |
Great :) I look forward do it |
I have just published the version '0.7.0' on CocoaPods. You can check it out. |
I am having a problem with the tapThrough functionality of the tabBar. Allowing tapThrough on a tabBar creates the following error: Here is the code I've used in the past to select a tabBar index: But here is the code in the MaterialShowcase.swift: I believe I need to pass the tabBarController somehow? |
@acali18 Ah yes, it's looking like this functionality is only working properly for standalone |
@poisondminds - Yes, that sounds correct. I will make the new issue. I wanted to discuss it first in case I had missed something. |
Created here: #118 |
Hello guys, any news to this? I am having the same issue as @acali18 . |
Any updates guys? |
Let me know if this needs more explanation.
Also, I did make changes to the sample app on my local machine to test this out, but didn't necessarily want to include them. Let me know if you'd want to see how I tested, or if you have trouble testing yourself.