Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor //str and //seq #234

Closed
marcelocantos opened this issue May 10, 2020 · 4 comments
Closed

Refactor //str and //seq #234

marcelocantos opened this issue May 10, 2020 · 4 comments
Assignees
@ericzhang6222
Labels
enhancement P0 High priority issue

Comments

@marcelocantos
Copy link
Contributor

Some functions currently in //str belong in //seq. Review and move.
@marcelocantos marcelocantos added enhancement P0 High priority issue labels May 10, 2020
@nofun97 nofun97 assigned ericzhang6222 and unassigned nofun97 May 11, 2020
@nofun97
Copy link
Contributor

nofun97 commented May 11, 2020

@ericzhang6222 we want to move a few functions from //str to //seq. These are the functions.

  1. contains
  2. sub
  3. split
  4. has_prefix
  5. has_suffix
  6. join

Currently these functions only work on string, you need to make them work for array and bytes too now

@ericzhang6222
Copy link
Contributor

@ericzhang6222 we want to move a few functions from //str to //seq. These are the functions.

  1. contains
  2. sub
  3. split
  4. has_prefix
  5. has_suffix
  6. join

Currently these functions only work on string, you need to make them work for array and bytes too now

Thx @nofun97

@ericzhang6222
Copy link
Contributor

ericzhang6222 commented May 11, 2020 •
edited
Loading

Following functions should be moved to //seq and SEQ will support string, byte array and array:

contains
sub
split
has_prefix
has_suffix
join

ericzhang6222 added a commit that referenced this issue May 11, 2020
@ericzhang6222
#234 Added new func to std_seq.go.
61b1845
ericzhang6222 added a commit that referenced this issue May 11, 2020
@ericzhang6222
#234 Fixed issue found by CI linter.
1ca6a25
@ericzhang6222 ericzhang6222 mentioned this issue May 12, 2020
Merged
2 tasks
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Move test cases to correct place.
cedb62b
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Check main body of changes.
7ca11fb
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Check main body of changes.
2a6453a
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Check in test case changes.
0074e35
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Added code to implement API .
2955085
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Added code to implement API .
854cb2e
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Removed funcs which have been moved to seq.
605ad83
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Made operator join work.
ba370be
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Added code to implement for rel.Array.
0e41758
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Fixed issue found by CI linter.
0a90275
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Fixed issue found by CI linter.
6aaf621
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Fixed issue found by CI linter.
2da4140
ericzhang6222 added a commit that referenced this issue May 12, 2020
@ericzhang6222
#234 Added some pseudo code.
b12e57f
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Fixed issue found by go lint.
6f21ca6
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Updated sample and docs as has_prefix has been moved to seq.
509fc6c
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Updated test cases as func changes in str.
81aa4cf
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Updated samples as func is moved from str tp seq.
7d421e3
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Updated docs as func is moved from str tp seq.
e53492a
ericzhang6222 added a commit that referenced this issue May 13, 2020
@ericzhang6222
#234 Update code to support has_prefix and has_suffix.
8ba80db
ericzhang6222 added a commit that referenced this issue May 19, 2020
@ericzhang6222
#234 Updated to make array split algorithm more straightforward.
9077692
ericzhang6222 added a commit that referenced this issue May 19, 2020
@ericzhang6222
#234 Updated to make array split algorithm more straightforward.
01d08fd
ericzhang6222 added a commit that referenced this issue May 20, 2020
@ericzhang6222
#234 Updated panic error..
3211949
ericzhang6222 added a commit that referenced this issue May 20, 2020
@ericzhang6222
#234 Updated docs and added more test cases..
07ba2e5
ericzhang6222 added a commit that referenced this issue May 20, 2020
@ericzhang6222
#234 Updated docs.'
520d461
ericzhang6222 added a commit that referenced this issue May 21, 2020
@ericzhang6222
#234 Removed unnecessary code as review comment.
b503c07
ericzhang6222 added a commit that referenced this issue May 21, 2020
@ericzhang6222
#234 Added more test case as review comment.
1cf5725
ericzhang6222 added a commit that referenced this issue May 21, 2020
@ericzhang6222
#234 Unpack args... to local variables and make code is more readable.
7d851f1
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Unpack args... to local variables to make code is more readable.
fd68a43
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Make sure the param subject in array join API has array type ele…
b230d30 
…ment only.
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Added more test cases.
2980a3b
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Fixed issue found by golang linter.
ea9149c
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Fixed issue found by golang linter.
8c81c1f
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Fixed issue found by golang linter.
40175e8
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Fixed incorrect test case.
3741ef4
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Changed code to make it is more readable.
9dbc9be
ericzhang6222 added a commit that referenced this issue May 22, 2020
@ericzhang6222
#234 Corrected std-seq.md sample.
a5d4bd4
ericzhang6222 added a commit that referenced this issue May 24, 2020
@ericzhang6222
#234 Merged latest code from master.
82837d6
ericzhang6222 added a commit that referenced this issue May 24, 2020
@ericzhang6222
#234 Fixed syntax error.
bf5e66e
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Updated code as code review comments.
5f912d0
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Fixed code conflicts.
a2b1aa3
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Fixed code conflicts, use new test API AssertCodeErrors.
c2bf772
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Updated code as review comments.
d1c3334
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Updated code as review comments.
9d719db
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Updated code as review comments.
8996b5c
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Fixed issue found by golang CI.
5a7c8b9
ericzhang6222 added a commit that referenced this issue May 25, 2020
@ericzhang6222
#234 Added new func to std_seq.go. (#240)
8cbfbb2 
1. Updated `seq` library to add functions that are used for manipulating sequenced data structures including string and array. These functions are: `contains`, `has_prefix`, `has_suffix`, `sub`, `split` and `join`.
2. Changed some APIs signature, like changed `//seq.sub(subject, old, new)` to `//seq.sub(old, new, subject)`. It can help to support following code:
```
let rmspace = //seq.sub(" ", "");
rmspace("hello world"), rmspace("a b c")]
```
@ericzhang6222
Copy link
Contributor

Fixed by #240

anzopensource pushed a commit that referenced this issue Nov 17, 2021
@hossarir
Merge pull request #234 from anzx/feature/logger-milliseconds
6f2fcc5 
Added milliseconds to logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericzhang6222 ericzhang6222

Labels
enhancement P0 High priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcelocantos @nofun97 @ericzhang6222