Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#234 Added new func to std_seq.go. #240

Merged
merged 136 commits into from
May 25, 2020
Merged

#234 Added new func to std_seq.go. #240

merged 136 commits into from
May 25, 2020

Conversation

ericzhang6222
Copy link
Contributor

@ericzhang6222 ericzhang6222 commented May 11, 2020

Changes proposed in this pull request:

contains
has_prefix
has_suffix
sub
split
join

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

@ericzhang6222 ericzhang6222 marked this pull request as draft May 11, 2020 15:36
@coveralls
Copy link

coveralls commented May 11, 2020

Pull Request Test Coverage Report for Build 5fb4eccd1741f4f943bd6fcf0c3901559cbf64cc-PR-240

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 89 of 105 (84.76%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.2%) to 43.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rel/value_set_array.go 0 1 0.0%
syntax/std_seq.go 89 104 85.58%
Files with Coverage Reduction New Missed Lines %
syntax/import_cache.go 1 80.49%
syntax/std_seq.go 3 87.25%
Totals Coverage Status
Change from base Build ff5e5b8981d84420ac3a884c1fab66d4e9186e5d: 1.2%
Covered Lines: 3327
Relevant Lines: 7623

💛 - Coveralls

docs/std-seq.md Outdated Show resolved Hide resolved
syntax/std_seq.go Outdated Show resolved Hide resolved
syntax/std_seq.go Outdated Show resolved Hide resolved
syntax/std_seq.go Outdated Show resolved Hide resolved
syntax/std_seq.go Outdated Show resolved Hide resolved
syntax/std_seq_contains_test.go Outdated Show resolved Hide resolved
syntax/std_seq_split_test.go Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/std-seq.md Outdated Show resolved Hide resolved
docs/std-seq.md Outdated Show resolved Hide resolved
docs/std-seq.md Outdated Show resolved Hide resolved
docs/std-seq.md Outdated Show resolved Hide resolved
syntax/std_seq.go Outdated Show resolved Hide resolved
@github-actions
Copy link

1 file(s) had their final line ending fixed:

  • docs/std-seq.md

@ericzhang6222 ericzhang6222 merged commit 8cbfbb2 into master May 25, 2020
@ericzhang6222 ericzhang6222 deleted the refactor-str-seq branch May 25, 2020 07:20
This was referenced May 25, 2020
anzopensource pushed a commit that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants