Fix listing display of Group Entries [WEB-2918] #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhiltri
requested changes
Aug 23, 2024
Comment on lines
62
to
76
| public function countAllChildren($entity) | ||
| { | ||
| $count = 0; | ||
| foreach ($entity->children as $child) { | ||
| if ($child->type !== DigitalPublicationArticleType::Grouping) { | ||
| $count += 1; | ||
| } | ||
|
|
||
| if ($child->children && $child->children->count() > 0) { | ||
| $count += $this->countAllChildren($child); | ||
| } | ||
| } | ||
| return $count; | ||
| } | ||
|
|
There was a problem hiding this comment.
The NestedSet package includes a descendants method that retrieves all children recursively: https://github.com/lazychaser/laravel-nestedset?tab=readme-ov-file#ancestors-and-descendants.
So rather than writing your own recursive method here, I think you can call $entity->descendants, ->filter() out items that have the type Grouping, then count the results.
web-dev-trev
force-pushed
the
fix/count-articles-recursively
branch
from
1473557
to
c79bf30
Compare
|
zachgarwood
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.