Update Dangerfile for noting tests, and stories on a PR #457
Conversation
orta
changed the title
orta
force-pushed
the
update_jest_danger
branch
from
9ea4e0d
to
23c77d5
Compare
|
Performance in tests is pretty terrible
I thought this was Danger's fault initially, but it isn't (older pr) - looks like a side-effect of the TS conversion. |
|
Bet this is the haste map generation - running tests twice "fixes it"
|
|
Can that be added to Travis’ cache? |
orta
force-pushed
the
update_jest_danger
branch
from
23c77d5
to
e1ee135
Compare
|
Yeah, they're in a determinate location, I've had to find it before |
|
Here we are: cacheDirectory |
dangerfile.ts
Outdated
| fail("No CHANGELOG added.") | ||
| } | ||
|
|
||
| // No PR is too small to warrent a paragraph or two of summary |
dangerfile.ts
Outdated
| warn(`${message} - <i>${idea}</i>`) | ||
| } | ||
|
|
||
| // Always ensure we assign someone, so that our Slackbot can do it's work correctly |
|
Good stuff 👌 |
orta
force-pushed
the
update_jest_danger
branch
from
e1ee135
to
3189058
Compare
|
Nits picked, and made a separate PR for jest cache. |
|
This just needs to wait on 0.14.1 - in putting this in a real project I found a bug, after that - good to go |
|
Deployment is via CI, so is indeterminate - you know what that's like ;) |
|
Ok, can you label this as WIP until that’s released? |
orta
force-pushed
the
update_jest_danger
branch
from
3189058
to
afebe2d
Compare
|
shipped ;) |
|
Hah, I see now what you meant by “deployment is via CI” :D |
|
OK 👍 this is good to go |
| @@ -6,6 +6,7 @@ | |||
| "rootDir": "src", | |||
| "outDir": "build", | |||
| "allowJs": true, | |||
| "pretty": true, | |||
There was a problem hiding this comment.
oh yeah, this just provides some extra colours when you see typescript errors in the console.
Adds the following:
WIP as I'm not sure it'll compile etc, I did it offline