Create a utils function for GitHub links #174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 3 3
Lines 93 93
Branches 17 17
=====================================
Misses 93 93Continue to review full report at Codecov.
|
source/dsl/DangerUtilsDSL.ts
Outdated
| @@ -5,7 +5,7 @@ | |||
| export interface DangerUtilsDSL { | |||
|
|
|||
| /** | |||
| * Creates an HTML link. | |||
| * Creates a HTML link. | |||
There was a problem hiding this comment.
ooooh. controversial. I guess this depends on how you pronounce 'H'. I say 'aitch', so 'an' makes sense. I guess it makes sense if you say 'haitch', or pronounce 'HTML' in some other way.
There was a problem hiding this comment.
hah - great point, I just asked my wife, she also agrees with you - instead, I'll re-write the sentence :D
| @@ -5,7 +5,7 @@ | |||
| export interface DangerUtilsDSL { | |||
|
|
|||
| /** | |||
| * Creates an HTML link. | |||
| * Creates a link using HTML. | |||
There was a problem hiding this comment.
The previous one is not wrong, but if I already tried fixing it, I bet we'd get people in the future doing the same 👯♂️
This builds on #134 to support easily making a list of GitHub clickable URLs - with this we can remove a great big chunk of Jest's and Emissions' Dangerfiles.
🌮