chore: switch fairs landing query to MP v2 #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandaroop
commented
Oct 1, 2020
| fairs: items { | ||
| ... on FeaturedLinkItem { | ||
| ... on FeaturedLink { |
There was a problem hiding this comment.
Not sure I fully followed the change btw v1 and v2 when it comes to this type, but this does work.
There was a problem hiding this comment.
Sweet! I think @dzucconi may have done some of the V2 updates for featured links? I don't fully recall these ones.
Merged
dblandin
added a commit
that referenced
this pull request
Oct 6, 2020
Quick follow-up to #6387 (FX-2329) to also migrate the client code to use Metaphysics V2.
artsy-peril bot
pushed a commit
that referenced
this pull request
Oct 6, 2020
Quick follow-up to #6387 (FX-2329) to also migrate the client code to use Metaphysics V2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/FX-2329
Keeping it simple, just changing the query, and aliasing fields as necessary.