Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FX-2329): Migrate desktop /fairs client to V2 #6428

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

dblandin
Copy link
Member

@dblandin dblandin commented Oct 6, 2020

Quick follow-up to #6387 (FX-2329) to also migrate the client code to use Metaphysics V2.

Quick follow-up to #6387 (FX-2329) to
also migrate the client code to use Metaphysics V2.
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good save, thanks 🙏

@@ -4,7 +4,7 @@ Backbone = require 'backbone'
CurrentUser = require '../../../models/current_user.coffee'
Profile = require '../../../models/profile.coffee'
initCarousel = require '../../../components/merry_go_round/bottom_nav_mgr.coffee'
metaphysics = require '../../../../lib/metaphysics.coffee'
metaphysics = require '../../../../lib/metaphysics2.coffee'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks!

(I see now that #6387 broke "view more past fairs" button 😭)

@anandaroop anandaroop added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 6, 2020
@artsy-peril artsy-peril bot merged commit c198c09 into master Oct 6, 2020
@artsy-peril artsy-peril bot mentioned this pull request Oct 7, 2020
@damassi damassi deleted the devon/fairs-desktop-migrate-mp-v2 branch October 7, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants