Skip to content

Commit

Permalink
Revert 138 revert 136 ovasdi/platform 5157/remove set output (#141)
Browse files Browse the repository at this point in the history
* Revert "Revert "chore: remove set-ouptut GHA workflow commands""

This reverts commit 5c13a31.

* fix: typo in environment variable

* refactor: wrap GITHUB_OUTPUT env var in double quotes
  • Loading branch information
ovasdi authored May 22, 2023
1 parent 4a6d23e commit b0ed8dd
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/facilitate-incident-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- name: Run CLI
id: cli
run: echo "PAYLOAD=$(artsy scheduled:facilitate-incident-review --useDatesVar)" >> $GITHUB_OUTPUT
run: echo "PAYLOAD=$(artsy scheduled:facilitate-incident-review --useDatesVar)" >> "$GITHUB_OUTPUT"
env:
OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }}
SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/next-on-call.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- name: Run CLI
id: cli
run: echo "::set-output name=payload::$(artsy scheduled:next-on-call)"
run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> "$GITHUB_OUTPUT"
env:
OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }}
SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }}
Expand All @@ -30,6 +30,6 @@ jobs:
uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: ${{steps.cli.outputs.payload}}
custom_payload: ${{steps.cli.outputs.PAYLOAD}}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
4 changes: 2 additions & 2 deletions .github/workflows/open-rfcs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ jobs:

- name: Run CLI
id: cli
run: echo "::set-output name=payload::$(artsy scheduled:rfcs)"
run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> "$GITHUB_OUTPUT"
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}

- name: Open RFCs > Slack
uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: ${{steps.cli.outputs.payload}}
custom_payload: ${{steps.cli.outputs.PAYLOAD}}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
6 changes: 3 additions & 3 deletions .github/workflows/recently-published.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ jobs:

- name: Run CLI
id: cli
run: echo "::set-output name=payload::$(artsy scheduled:recently-published)"
run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> "$GITHUB_OUTPUT"
env:
SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }}

- name: Standup Reminder > Slack
uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: ${{steps.cli.outputs.payload}}
custom_payload: ${{steps.cli.outputs.PAYLOAD}}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
6 changes: 3 additions & 3 deletions .github/workflows/standup-reminder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- name: Run CLI
id: cli
run: echo "::set-output name=payload::$(artsy scheduled:standup-reminder)"
run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> "$GITHUB_OUTPUT"
env:
OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }}
SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }}
Expand All @@ -30,6 +30,6 @@ jobs:
uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: ${{steps.cli.outputs.payload}}
custom_payload: ${{steps.cli.outputs.PAYLOAD}}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

0 comments on commit b0ed8dd

Please sign in to comment.