Revert 138 revert 136 ovasdi/platform 5157/remove set output #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblandin
approved these changes
May 22, 2023
.github/workflows/next-on-call.yml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
|
|
|||
| - name: Run CLI | |||
| id: cli | |||
| run: echo "::set-output name=payload::$(artsy scheduled:next-on-call)" | |||
| run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
suggestion / non-blocking: Might be a good idea to double quote this environment variable name, just in case something changes internally that includes an unexpected space.
Suggested change
| run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> $GITHUB_OUTPUT | |
| run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> "$GITHUB_OUTPUT" |
dblandin
deleted the
revert-138-revert-136-ovasdi/PLATFORM-5157/remove-set-output
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the revert and includes a fix to address the typo in GITHUB environment variable.
Example of the GHA which didn't contain the typo succeeding this morning.