Simplify development environment setup via Docker Compose #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
force-pushed
the
dockerize-dev-environment
branch
3 times, most recently
from
e739d49 to
62a20ab
Compare
kanaabe
approved these changes
Aug 14, 2017
yuki24
reviewed
Aug 15, 2017
| @@ -7,6 +7,7 @@ ARTSY_URL=http://localhost:5000/__gravity | |||
| SESSION_SECRET=p0s1tr0n | |||
| MONGOHQ_URL=mongodb://localhost:27017/positron-test | |||
| ELASTICSEARCH_URL=http://localhost:9200 | |||
| ELASTICSEARCH_PORT=9200 | |||
There was a problem hiding this comment.
This also needs to be added to .env.example.
| ports: | ||
| - "${ELASTICSEARCH_PORT}:${ELASTICSEARCH_PORT}" | ||
| mongodb: | ||
| image: mongo:latest |
There was a problem hiding this comment.
I was getting a connection error from mongo client. I might be missing something, but possibly the port for mongodb also needs to be forwarded and exposed like it is for elasticsearch?
ports:
- 27017:27017
|
👏 great PR @damassi! I wish positron had this before I set that up. |
damassi
force-pushed
the
dockerize-dev-environment
branch
from
62a20ab to
6466c93
Compare
bhoggard
reviewed
Aug 16, 2017
| ports: | ||
| - "${ELASTICSEARCH_PORT}:${ELASTICSEARCH_PORT}" | ||
| mongodb: | ||
| image: mongo:latest |
There was a problem hiding this comment.
You should lock to a specific version. Production is running 3.0.6, so I would set it to
mongo:3.0
bhoggard
reviewed
Aug 16, 2017
| WORKDIR /usr/src/app | ||
| COPY package.json . | ||
| COPY . . | ||
| RUN yarn install |
There was a problem hiding this comment.
To avoid docker cache invalidation, do yarn install before the second COPY command.
bhoggard
reviewed
Aug 16, 2017
| version: '2' | ||
| services: | ||
| elasticsearch: | ||
| image: elasticsearch:latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP as I need to test a few things out, but what this PR does is wrap all of our local development environment services (mongo, elasticsearch, node) into one command
docker-compose up. This allows us to keep things contained when working locally and free of global installs. Future setup is along the lines ofdocker-compose upNote that this only applies only to local development environments and does not change existing deployment configuration.