Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Docker feedback #1236

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Address Docker feedback #1236

merged 1 commit into from
Aug 16, 2017

Conversation

damassi
Copy link
Member

@damassi damassi commented Aug 16, 2017

Addresses feedback located here #1221 (thanks @bhoggard)

@damassi damassi self-assigned this Aug 16, 2017
@damassi damassi merged commit 1202682 into artsy:master Aug 16, 2017
@damassi damassi deleted the docker-updates branch August 16, 2017 01:20
@yuki24
Copy link
Contributor

yuki24 commented Aug 16, 2017

👍

@bhoggard
Copy link

Almost there. The yarn install has to be run after COPY package.json ..

@damassi
Copy link
Member Author

damassi commented Aug 16, 2017

Oh yeah this was updated in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@damassi damassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damassi @yuki24 @bhoggard