Stub out new API for collection hub nav item #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
Jira Synced
Version: Patch
Signed-off-by: Steve Hicks <steven.j.hicks@gmail.com>
This defaults to the spacing in the desktop comp. Any other Serif props will simply be passed through.
ImageLink is meant to be reusable in different contexts, so will be invoked directly at the call site. Signed-off-by: Steve Hicks <steven.j.hicks@gmail.com>
…nav-item Continue refactor of hubs nav to accommodate homepage usage
pepopowitz
changed the title
anandaroop
approved these changes
Aug 27, 2019
|
🚀 PR was released in v17.7.4 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collaboration with @anandaroop.
As part of putting collection hubs on the home page (https://artsyproduct.atlassian.net/browse/GROW-1360), we need to make the CollectionsHubsNavItem more dynamic. Different entry points will use different font sizes, and some have titles while others have titles and subtitles.
This PR accomplishes that by replacing the
CollectionsHubsNavItemwith a more generalImageLinkcomponent, which expects thetitleandsubtitleto be passed in by the caller.