Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork PRs that have had PRs merged into them cause the release to fail #535

Closed
zephraph opened this issue Aug 27, 2019 · 3 comments · Fixed by #537
Closed

Fork PRs that have had PRs merged into them cause the release to fail #535

zephraph opened this issue Aug 27, 2019 · 3 comments · Fixed by #537
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@zephraph
Copy link
Collaborator

Describe the bug

artsy/reaction#2730 is a PR that was created from a fork. That fork had a PR (pepopowitz/reaction#3) merged into it (from another fork).

Now releases are broken because it's trying to look up a PR at artsy/reaction/pull/3 when it should be looking up the PR from pepopowitz/reaction/pull/3

Additional context

Here's the CI build: https://circleci.com/gh/artsy/reaction/42174

@zephraph zephraph added the bug Something isn't working label Aug 27, 2019
@hipstersmoothie
Copy link
Collaborator

related: #465

@hipstersmoothie
Copy link
Collaborator

Other related bugs:

  1. commit with add auto release to CI #1 has been merged, a second message with add auto release to CI #1 is merged and it thinks add auto release to CI #1 has been released again
  2. commit with Deprecate --major --minor --patch flags #100 merged, repo has < 100 issues, results in 404
  3. merging back and forth from 2 prs, potentially many repeated pr numbers

@adierkens
Copy link
Collaborator

🚀 Issue was released in v7.3.5 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants