Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --major --minor --patch flags #100

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

Remove --major --minor --patch flags from pr-check and version

Why

There are more versioning labels than this and that many flags is confusing. They also weren't being used.

closes #61

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #100 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #100      +/-   ##
========================================
+ Coverage   74.97%    75%   +0.02%     
========================================
  Files          13     13              
  Lines         947    940       -7     
  Branches      133    132       -1     
========================================
- Hits          710    705       -5     
+ Misses        209    208       -1     
+ Partials       28     27       -1
Impacted Files Coverage Δ
src/main.ts 23.67% <ø> (-0.14%) ⬇️
src/cli/args.ts 91.25% <ø> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769a150...5625e18. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #100 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #100      +/-   ##
========================================
+ Coverage   74.97%    75%   +0.02%     
========================================
  Files          13     13              
  Lines         947    940       -7     
  Branches      133    132       -1     
========================================
- Hits          710    705       -5     
+ Misses        209    208       -1     
+ Partials       28     27       -1
Impacted Files Coverage Δ
src/main.ts 23.67% <ø> (-0.14%) ⬇️
src/cli/args.ts 91.25% <ø> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769a150...5625e18. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate auto version flags major, minor, patch
1 participant