Deprecation of Options destinationDir

[abelsromero]

I am confused about the use of destinationDir vs toDir, I suspect they are the same and maybe the first one could be marked as deprecated to avoid confusion to users.
Seeing this code
https://github.com/asciidoctor/asciidoctor/blob/1d61da9ee0aba63711c415fa629a80f275036aa4/lib/asciidoctor/cli/invoker.rb#L59 and the user manual https://asciidoctor.org/docs/user-manual/#ruby-api-options, seems pretty obvious but I wanted to contrast and maybe check if this has some history reason.

[robertpanzer]

Interesting. We definitely need to do some investigation on this.
For the command line option we follow the behavior of the Asciidoctor Ruby Invoker and set to_dir:

asciidoctorj/asciidoctorj-core/src/main/java/org/asciidoctor/jruby/cli/AsciidoctorCliOptions.java

Lines 321 to 322 in 7456234

	if (isDestinationDirOption() && !isOutputStdout()) {
	optionsBuilder.toDir(new File(this.destinationDir));

But I can imagine that calling Options.setDestinationDir() could be completely useless, just looking at the code it seems like Asciidoctor would never look at this option when set from the API.

[abelsromero]

It seems to me destinationDir is just a front-end for to_dir. I suspect for Python compatiblity https://github.com/asciidoc/asciidoc-py3/search?q=destination%3A&unscoped_q=destination%3A. While there's a mention of destinationDir and destination_dir in the code, there's no to_dir.