Remove invalid destinationDir option from API for v3.0.x #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-853-remove-invalid-destinationDir-option
branch
2 times, most recently
from
9da0c8c
to
369acd8
Compare
The option only is used for the CLI, in that case the value is redirected to 'to_dir'. Fixes asciidoctor#853 Fixes asciidoctor#941
5 tasks
abelsromero
changed the title
Yep, killed 2 birds with 1 stone :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Fix the issue where using the option
destinationDirfrom API had no effect.The option only is used for the CLI, in that case the value is redirected to 'to_dir'.
How does it achieve that?
OptionsBuilderandOptionsclass.OptionstoAsciidoctorUtils: this is the second time I struggle with this class. It's out of place because it contains CLI elements to build the asciidoctor command for logging purposes in the core. So to prevent cyclic dependencies some constants are copied both here and in theasciidoctor-clisub-module -> Solution = create new sub-module "shared" or remove the logging. Third time will be the charm 🤔Are there any alternative ways to implement this?
Initial conversations are about deprecations, but I think it's the moment to do some clean up and breaking changes for v3.0.0.
Are there any implications of this pull request? Anything a user must know?
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #853
Fixes #941
2️⃣ in 1️⃣ 😁
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc