Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 1.0.0 (remove prerelease text) #23

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

paulrayner
Copy link
Member

This will enable the gem to be installed from Rubygems via gem install jekyll-asciidoc (per the instructions in the README) without having to specify the --pre flag. Since we are releasing this as a gem for production use, seems that v.1.0.0 is appropriate. WDYT? Once this is done I will re-publish the gem to Rubygems.

This will enable the gem to be installed from Rubygems via `gem install jekyll-asciidoc` (per the instructions in the README) without having to specify the `--pre` flag. Since we are releasing this as a gem for production use, seems that v.1.0.0 is appropriate. WDYT?
@mojavelinux
Copy link
Member

Since we are releasing this as a gem for production use, seems that v.1.0.0 is appropriate.

I'm a big fan of starting to 1.0.0. It gives us access to all the version number slots to manage future releases right from the start.

This code has been in use long enough that I think we're definitely ready for a first production release. Let's get confirmation from @eshepelyuk and other users if possible that the gem functions correctly (as we expect it does), then let's move forward with the release. I'd be glad to test if you need me to.

@mojavelinux
Copy link
Member

...works great for me!

@eshepelyuk
Copy link
Contributor

Works for me, both locally and on TravisCI

paulrayner pushed a commit that referenced this pull request Jan 6, 2015
Set version to 1.0.0 (remove prerelease text)
@paulrayner paulrayner merged commit c60f00f into asciidoctor:master Jan 6, 2015
@eshepelyuk
Copy link
Contributor

Any estimation on the terms of 1.0.0 availability via RubyGems site ?

@mojavelinux
Copy link
Member

I think we're ready.

@eshepelyuk
Copy link
Contributor

Just, checked - 1.0.0 not yet available. As far as I understand - just need some more time to wait ?

@mojavelinux
Copy link
Member

Sorry, I was unclear. What I meant is that we are ready to publish the 1.0.0, as soon as Paul is ready. Paul is the "release engineer" for the gem :)

Paul, you should add yourself to the list of authors in the gemspec so that you get listed as such on the rubygems.org/gems/jekyll-asciidoc. If you are releasing the gem, you are definitely one of the authors (if you want to be) :)

@eshepelyuk
Copy link
Contributor

Thanks for the explanation :) Will wait for @paulrayner then.
Also I've created PR #24 with some changes to plugin installation description.
Could you both please review it ?

@mojavelinux
Copy link
Member

It would be good to get those documentation changes merged in preparation for the 1.0.0 release. I left some comments on the pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants