Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements - Bundler, front matter #24

Merged
merged 5 commits into from
Jan 7, 2015
Merged

Documentation improvements - Bundler, front matter #24

merged 5 commits into from
Jan 7, 2015

Conversation

eshepelyuk
Copy link
Contributor

I propose some changes to make cleaner separation of plugin management and site building when using Bundler

Ievgenii.Shepeliuk added 2 commits January 6, 2015 09:50

$ gem install jekyll-asciidoc`
$ bundle install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the "install" part is not required. "install" is the default action for the bundle command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree, but in this case my intention was to make command line to be more 'self-explanatory', for instance for people not familiar with Bundler.
Although, I can delete install if you prefer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose what you feel is best. I was just pointing it out. It was only recently I learned this trick.

@mojavelinux
Copy link
Member

Thanks for updating the instructions! I added some comments inline with some suggested revisions.

@eshepelyuk
Copy link
Contributor Author

Fixed some of the issues, commented on others.

@eshepelyuk eshepelyuk changed the title Documentation improvements regarding using Bundler Documentation improvements - Bundler, front matter Jan 7, 2015
@mojavelinux
Copy link
Member

Looks good!

@eshepelyuk
Copy link
Contributor Author

So, let's wait for @paulrayner to merge PR and then release 1.0.0 gem ?

paulrayner pushed a commit that referenced this pull request Jan 7, 2015
@paulrayner paulrayner merged commit 621193b into asciidoctor:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants