Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "milestone" releases are not excluded when searching for "latest" version #1306

Closed
log2 opened this issue Jul 19, 2022 · 2 comments · Fixed by #1307 or #1273
Closed

bug: "milestone" releases are not excluded when searching for "latest" version #1306

log2 opened this issue Jul 19, 2022 · 2 comments · Fixed by #1307 or #1273
Labels

Comments

@log2
Copy link
Contributor

log2 commented Jul 19, 2022

Describe the Bug

asdf latest xyz should not list, and thus select, *-milestone-* releases of xyz plugin.

However, asdf latest gradle shows 7.5-milestone-1 as latest, since it is the last line in asdf list-all gradle.

Steps to Reproduce

  1. Enter asdf plugin add gradle
  2. Enter asdf latest gradle

Expected Behaviour

asdf latest should not show a non-release version, such as *-milestone-*

Actual Behaviour

Version 7.5-milestone-1 is shown, rather than actual latest, stable version 7.5

Environment

OS:
Darwin Mac-mini-di-Lorenzo-3.local 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64

SHELL:
zsh 5.8.1 (x86_64-apple-darwin21.0)

ASDF VERSION:
v0.10.2

ASDF ENVIRONMENT VARIABLES:
ASDF_DIRENV_BIN=/Users/log2/.asdf/installs/direnv/2.32.1/bin/direnv
ASDF_DATA_DIR=/Users/log2/.asdf
ASDF_DIR=/Users/log2/.asdf-code

ASDF INSTALLED PLUGINS:
alias                        https://github.com/andrewthauer/asdf-alias.git master 94da3a7
awscli                       https://github.com/MetricMike/asdf-awscli.git main c645552
cosign                       https://gitlab.com/wt0f/asdf-cosign.git main ee306c4
direnv                       https://github.com/asdf-community/asdf-direnv.git master a5aefdf
dive                         https://github.com/looztra/asdf-dive.git master 1321207
eksctl                       https://github.com/elementalvoid/asdf-eksctl.git master 5309e4b
flux2                        https://github.com/tablexi/asdf-flux2.git master 771755e
gcloud                       https://github.com/jthegedus/asdf-gcloud.git main f59e332
gradle                       https://github.com/rfrancis/asdf-gradle.git master 34e1e36
grype                        https://github.com/poikilotherm/asdf-grype.git main d6e0ece
helm                         https://github.com/Antiarchitect/asdf-helm.git master a39e17b
java                         https://github.com/halcyon/asdf-java.git master 9490cdc
jq                           https://github.com/azmcode/asdf-jq.git master 844d712
k3d                          https://github.com/spencergilbert/asdf-k3d.git main dc2358d
k9s                          https://github.com/looztra/asdf-k9s.git master 2102e69
kind                         https://github.com/johnlayton/asdf-kind.git master 4b6ed61
kubectl                      https://github.com/Banno/asdf-kubectl.git master 11ac5c3
kubectx                      https://gitlab.com/wt0f/asdf-kubectx.git master 8c0b4aa
kubespy                      https://github.com/jfreeland/asdf-kubespy.git main 08a4aba
kubeval                      https://github.com/stefansedich/asdf-kubeval.git master 6ccc18f
kustomize                    https://github.com/Banno/asdf-kustomize.git master 2efaa38
maven                        https://github.com/halcyon/asdf-maven.git master add7c1c
nova                         https://github.com/elementalvoid/asdf-nova.git master f9220a7
pre-commit                   https://github.com/jonathanmorley/asdf-pre-commit.git master 26bfc42
python                       https://github.com/danhper/asdf-python.git master 57ef777
semver                       https://github.com/mathew-fleisch/asdf-semver.git main fdab9b7
shfmt                        https://github.com/luizm/asdf-shfmt.git master f893252
sops                         https://github.com/feniix/asdf-sops.git master 954411c
syft                         https://github.com/davidgp1701/asdf-syft.git main f070c59
terraform                    https://github.com/Banno/asdf-hashicorp.git master bc4dec6
trivy                        https://github.com/zufardhiyaulhaq/asdf-trivy.git master 537a22a
websocat                     https://github.com/bdellegrazie/asdf-websocat.git master cdfb1eb
yq                           https://github.com/sudermanjr/asdf-yq.git master 772992f


### asdf plugins affected (if relevant)

gradle                       https://github.com/rfrancis/asdf-gradle.git master 34e1e36
@jthegedus
Copy link
Contributor

Note: plugin authors can provide this functionality themselves with a bin/latest-stable script.

@Stratus3D
Copy link
Member

Note: plugin authors can provide this functionality themselves with a bin/latest-stable script.

This is the preferred solution going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants