-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite: Absolute basics #713
Conversation
1ab5e3d
to
c45953c
Compare
Responding to early feedback about this PR, I've changed it to keep the old generator in the code base as a reference point and I've changed the base branch to |
@Friz64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple, this should allow us to more easily compare the new generated version to the old one. Which of course only makes sense if the new one looks similar to the old one... and that is exactly the feedback I have heard/received over time: ash
works well for many users as a low-level no-frills and they really wouldn't want to deal with (much) more API breakage nor see any need for it. In other words, and as said before I really don't intend to rewrite/redesign ash
, only the generator needs to be rewritten to deal with increasing complexity in vk.xml
resulting in an unmaintainable hunk of code. Changes to ash
itself should mostly be incremental, such as perhaps autogenerating the hand-written helpers, including more/better documentation, properly guarding experimental APIs behind cfg
and so forth.
For this PR that mainly comes down to leaving README.md
intact, especially if we merge this to master
instead of instantiating a special rewrite
branch.
And if folks don't align with my view here, let's discuss. Incremental changes/improvements to ash
is still rather broad, and I am open to breaking changes.
Okay! Now it probably makes more sense to directly work from |
Looks like CI broke because |
Ugh, I'm also running into that MSRV break on the |
FYI I rebased this. |
Let's get it in then and get this show on the road! |
This PR intends to lay a groundwork for the rewrite.
Here are my changes