Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ash-window: Bump MSRV to 1.64 to match raw-window-handle 0.5.1 #716

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Mar 9, 2023

raw-window-handle 0.5.1 bumped from 1.60 to 1.64 in a semver-compatible release, failing our CI infrastructure overnight.

Keep the ash version at 1.60 for now. Lower ash to 1.59 because the original bump in #709 was only to match winit 0.28/objc, both of which are not used by the ash crate.

`raw-window-handle 0.5.1` bumped from 1.60 to 1.64 in a
semver-compatible release, failing our CI infrastructure overnight.

Keep the `ash` version at `1.60` for now.
@MarijnS95 MarijnS95 changed the title ash-window: Bump MSRV to 1.64 to match raw-window-handle 0.5.1 Bump ash-window MSRV to 1.64 to match raw-window-handle 0.5.1 and lower ash MSRV to 1.59 Mar 9, 2023
@MarijnS95 MarijnS95 changed the title Bump ash-window MSRV to 1.64 to match raw-window-handle 0.5.1 and lower ash MSRV to 1.59 Bump ash-window MSRV to 1.64 to match raw-window-handle 0.5.1 and lower ash MSRV back to 1.59 Mar 9, 2023
@MarijnS95
Copy link
Collaborator Author

Lower ash to 1.59 because the original bump in #709 was only to match winit 0.28/objc, both of which are not used by the ash crate.

Seems like I did not document it, but even if we use -p ash to only compile Ash on 1.59, the compiler first tries to understand the entire crate graph and somehow fails on objc yet again, while it is fine on 1.60 (https://github.com/ash-rs/ash/actions/runs/4374927457) despite having MSRV-1.64 elsewhere in the not-actively-compiled dependency graph.

We could solve this by either sed'ing those crates out of the workspace, or dropping the second commit again and sticking to 1.60 for Ash (wasn't released yet). Thoughts?

@Friz64
Copy link
Contributor

Friz64 commented Mar 9, 2023

By saying "sed'ing those crates out of the workspace", are you suggesting to remove their reference in the Cargo.toml workspace members section? If I'm understanding this correctly I'd rather opt to remove the second commit and take the hit of one Rust version.

@MarijnS95
Copy link
Collaborator Author

By saying "sed'ing those crates out of the workspace", are you suggesting to remove their reference in the Cargo.toml workspace members section?

Yes.

If I'm understanding this correctly I'd rather opt to remove the second commit and take the hit of one Rust version.

Sure, let's keep it at 1.60, otherwise users cloning this repo on 1.59 can't repro a successful build either.

@MarijnS95 MarijnS95 changed the title Bump ash-window MSRV to 1.64 to match raw-window-handle 0.5.1 and lower ash MSRV back to 1.59 ash-window: Bump MSRV to 1.64 to match raw-window-handle 0.5.1 Mar 9, 2023
@MarijnS95 MarijnS95 changed the title ash-window: Bump MSRV to 1.64 to match raw-window-handle 0.5.1 ash-window: Bump MSRV to 1.64 to match raw-window-handle 0.5.1 Mar 9, 2023
@MarijnS95 MarijnS95 merged commit 1c9e422 into master Mar 9, 2023
@MarijnS95 MarijnS95 deleted the msrv-1.64 branch March 9, 2023 22:39
MarijnS95 added a commit that referenced this pull request Apr 2, 2023
`raw-window-handle 0.5.1` bumped from 1.60 to 1.64 in a
semver-compatible release, failing our CI infrastructure overnight.

Keep the `ash` version at `1.60` for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants