Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Change Microsoft.AspNet.Hosting.ini to Microsoft.AspNet.Hosting.json #269

Closed
PonchoPowers opened this issue May 13, 2015 · 9 comments
Closed
Assignees
Milestone

Comments

@PonchoPowers
Copy link

This might already be planned but I'm raising it here as there are many references to Microsoft.AspNet.Hosting.ini in examples on websites giving an insight into ASP.NET 5, which is likely to cause confusion if the file is changed from an ini to a json file, so if we are going to use json files it would be better if we switched sooner rather than later.

@PonchoPowers
Copy link
Author

Pull request: #270

@Mike-E-angelo
Copy link

It does cause confusion and does not reflect well on the project structure/composition or overall design. A provider model to load the configuration would be ideal, as this would make it consistent with the overarching ASP.NET5 configuration model. Even more ideal, they should both use the same components. This would/should default to .json, but would enable .xml/.ini/.xaml/.yaml/.etc if desired. Related issue: aspnet/Tooling#140

@Mike-E-angelo
Copy link

Horray... very cool. Some sanity restored. :) Are there plans to make this more consistent with the rest of ASP.NET's configuration model and allow providers to dictate the configuration format?

@Tratcher
Copy link
Member

Tratcher commented Sep 8, 2015

Not at the moment. You can open a separate issue.

@Mike-E-angelo
Copy link

Cool. Done. Thank you!

@davidfowl
Copy link
Member

That would require a plugin model for config format since hosting won't depend on every format possible

@davidfowl
Copy link
Member

I think if you wanted that you'd be better off constructing the host in your own program main

@Mike-E-angelo
Copy link

Exactly. The plugin model is already in use elsewhere and can be used here as well. It obviously already has two different formats that users favor, so why not open it up to all formats if it's the same amount of work to do?

@Mike-E-angelo
Copy link

There is also the issue of providing proper guidance here in case someone else gets a crazy idea somewhere down the line to also use .ini or (god forbid) .xml :)

shrayasr added a commit to shrayasr/aspnet-middleware-sample that referenced this issue Dec 16, 2015
- Use coreclr version
- Point global.json to the latest rc1-update1 coreclr
- Use Kestrel instead of WebListener
- Multiple changes have occured from beta5 to rc1. Some of the major
  ones are:
  - Microsoft.Framework.* renamed to Microsoft.Extensions.* (aspnet/Announcements#77)
  - Hosting.ini is deprecated in favour of a json model (aspnet/Hosting#269)
  - IHeaderDictionary.TryGetValue now uses a StringValue out
    parameter instead of a string[] out parameter (aspnet/HttpAbstractions@456277f)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants