Use a json file instead of an ini file to configure hosting environment #270
Conversation
|
Hi @Matthew-Bonner, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
Hi @Matthew-Bonner, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
| @@ -12,7 +12,7 @@ namespace Microsoft.AspNet.Hosting | |||
| { | |||
| public class Program | |||
| { | |||
| private const string HostingIniFile = "Microsoft.AspNet.Hosting.ini"; | |||
| private const string HostingJsonFile = "Microsoft.AspNet.Hosting.json"; | |||
There was a problem hiding this comment.
Perhaps it would be better to simply support both? Prefer json first, if not present, look for ini?
There was a problem hiding this comment.
What is the point? The whole idea of switching to JSON is to make this consistent with where everything else is headed, and to avoid overcomplicating something which does not need to be complex we should only support one language opposed to many. So we might as well ditch the ini file now so that we can give people time to update their projects and then we can work on more pressing issues.
There was a problem hiding this comment.
Yea we're just going to use json forget the ini file.
|
I would like to vote for both .json & .ini. You are able to configure ASP.NET in any format you want as long as there is a provider, correct? Why not make it the same here? |
|
@Matthew-Bonner Could you rebase the PR? @Tratcher Could you take this in? |
|
@Matthew-Bonner don't worry about it, I'll take care of it. |
|
Rebased, updated, and merged. |
|
Thanks guys 👍 |
No description provided.