Add Generic arguments for IdentityUser and UserStore #643
Conversation
Moved Identity* classes to defaults on an open Generic type base class for UserStore and IdentityUser Added implicit casts for IdentityUserClaim and IdentityUserLogin with virtual implementations
pull commits from asp.net 30/Oct
Conflicts: src/Microsoft.AspNet.Identity.EntityFramework/IdentityUser.cs src/Microsoft.AspNet.Identity.EntityFramework/UserStore.cs Syncing to RC1
|
Hi @slaneyrw, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
This also could satisfy issue #596 |
Extended RoleStore Extended IdentityDbContext
Changes to run tests on coreclr with moq.netcore
|
We're not planning on taking this for RTM but we will revisit this for vnext |
|
There goes the upgrade path for our application. Not going to be bother to fix the pull request for the ASP.NET Core namespace change, really isn't any point is there! |
|
We discussed this and willing to try and get this in for RC2, once any issues in review are addressed |
| @@ -66,6 +67,89 @@ protected IdentityDbContext() | |||
| { | |||
|
|
|||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we call these methods something more like CreateXyzModel instead of OnBuild since these are called from OnModelCreating?
|
We shouldn't rush this in for RC2 but instead do it early into the next milestone, so moving. |
|
Replaced by #798 |
Refer to issue #585