Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Initial generics support #798

Closed
wants to merge 6 commits into from
Closed

Initial generics support #798

wants to merge 6 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Apr 13, 2016

Hand merge with some changes from #643

Assert.Equal(claim.Issuer, newClaim.Issuer);
}

[Fact]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divega This test depends on the ability to affect querys using the "logincontext" to affect the filter. So this is a scenario which required customizing the LINQ query

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative way for this scenario to work without exposing all of the querys, would be to extend the user manager and overriding the behavior of the methods to do the right thing, either via new store api or directly applying a query.

@HaoK
Copy link
Member Author

HaoK commented Apr 14, 2016

@divega This PR has been updated as we discussed, I removed the test that was trying to customize and changing the uniqueness of our login providers, the other 2 tests pass. I also copied the test over to the SqlServer, and those pass as well, so I think this should be good to go.

@slaneyrw
Copy link

Great to see this is now getting traction... thanks for listening

/// Reads the type and value from the Claim.
/// </summary>
/// <param name="claim"></param>
public virtual void FromClaim(Claim claim)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize

@HaoK
Copy link
Member Author

HaoK commented May 23, 2016

104f216

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants