Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-logging-format] Fix the autofix title in logging-warn (G010) #11514

Merged
merged 2 commits into from
May 24, 2024

Conversation

monk-time
Copy link
Contributor

Summary

Rule logging-warn (G010) prescribes a change from warn to warning and has a corresponding autofix, but the autofix is mistakenly titled "Convert to `warn`" instead of "Convert to `warning`" (the latter is what the autofix actually does). Seems to be a plain typo.

Test Plan

I apologize for not being able to properly test this at the moment, the change was made by grepping the repo and fixing the typo in code as well as in the .snap file.

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I apologize for not being able to properly test this at the moment, the change was made by grepping the repo and fixing the typo in code as well as in the .snap file.

Well, the CI is green so everything must have been updated ;)

@dhruvmanila dhruvmanila merged commit 3e30962 into astral-sh:main May 24, 2024
19 checks passed
@monk-time monk-time deleted the autofix-g010-typo branch May 24, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants