Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-logging-format] Fix the autofix title in logging-warn (G010) #11514

Merged
merged 2 commits into from
May 24, 2024
Merged

[flake8-logging-format] Fix the autofix title in logging-warn (G010) #11514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
010570a
Update autofix text in violations.rs
monk-time May 23, 2024
f1877a5
Update test snapshot
monk-time May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...8_logging_format/snapshots/ruff_linter__rules__flake8_logging_format__tests__G010.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ G010.py:6:9: G010 [*] Logging statement uses `warn` instead of `warning`
7 | log.warn("Hello world!") # This shouldn't be considered as a logger candidate
8 | logger.warn("Hello world!")
|
= help: Convert to `warn`
= help: Convert to `warning`

ℹ Safe fix
3 3 |
Expand All @@ -31,7 +31,7 @@ G010.py:8:8: G010 [*] Logging statement uses `warn` instead of `warning`
9 |
10 | logging . warn("Hello World!")
|
= help: Convert to `warn`
= help: Convert to `warning`

ℹ Safe fix
5 5 |
Expand All @@ -52,7 +52,7 @@ G010.py:10:11: G010 [*] Logging statement uses `warn` instead of `warning`
11 |
12 | from logging import warn, warning, exception
|
= help: Convert to `warn`
= help: Convert to `warning`

ℹ Safe fix
7 7 | log.warn("Hello world!") # This shouldn't be considered as a logger candidate
Expand All @@ -72,7 +72,7 @@ G010.py:13:1: G010 [*] Logging statement uses `warn` instead of `warning`
14 | warning("foo")
15 | exception("foo")
|
= help: Convert to `warn`
= help: Convert to `warning`

ℹ Safe fix
10 10 | logging . warn("Hello World!")
Expand Down
2 changes: 1 addition & 1 deletion crates/ruff_linter/src/rules/flake8_logging_format/violations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ impl AlwaysFixableViolation for LoggingWarn {
}

fn fix_title(&self) -> String {
"Convert to `warn`".to_string()
"Convert to `warning`".to_string()
}
}

Expand Down
Loading