[flake8-pytest-style] Rewrite references to .exception (PT027)
#15680
+303
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| ANN201 | 4 | 2 | 2 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+3 -3 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
apache/superset (+3 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- tests/integration_tests/charts/schema_tests.py:59:9: PLR6301 Method `test_query_context_series_limit` could be a function, class method, or static method + tests/integration_tests/charts/schema_tests.py:59:9: PLR6301 Method `test_query_context_series_limit` could be a function, class method, or static method - tests/integration_tests/model_tests.py:202:9: PLR6301 Method `test_adjust_engine_params_mysql` could be a function, class method, or static method + tests/integration_tests/model_tests.py:202:9: PLR6301 Method `test_adjust_engine_params_mysql` could be a function, class method, or static method + tests/integration_tests/viz_tests.py:899:9: ANN201 Missing return type annotation for public function `test_apply_rolling_without_data` - tests/integration_tests/viz_tests.py:899:9: ANN201 Missing return type annotation for public function `test_apply_rolling_without_data`
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLR6301 | 4 | 2 | 2 | 0 | 0 |
| ANN201 | 2 | 1 | 1 | 0 | 0 |
MichaReiser
approved these changes
Jan 23, 2025
crates/ruff_linter/src/rules/flake8_pytest_style/rules/assertion.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pytest_style/rules/assertion.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pytest_style/rules/assertion.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pytest_style/rules/assertion.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Jan 23, 2025
dcreager
added a commit
that referenced
this pull request
Jan 24, 2025
* main: Add `check` command (#15692) [red-knot] Use itertools to clean up `SymbolState::merge` (#15702) [red-knot] Add `--ignore`, `--warn`, and `--error` CLI arguments (#15689) Use `uv init --lib` in tutorial (#15718) [red-knot] Use `Unknown | T_inferred` for undeclared public symbols (#15674) [`ruff`] Parenthesize fix when argument spans multiple lines for `unnecessary-round` (`RUF057`) (#15703) [red-knot] Rename `TestDbBuilder::typeshed` to `.custom_typeshed` (#15712) Honor banned top level imports by TID253 in PLC0415. (#15628) Apply `AIR302`-context check only in `@task` function (#15711) [`airflow`] Update `AIR302` to check for deprecated context keys (#15144) Remove test rules from JSON schema (#15627) Add two missing commits to changelog (#15701) Fix grep for version number in docker build (#15699) Bump version to 0.9.3 (#15698) Preserve raw string prefix and escapes (#15694) [`flake8-pytest-style`] Rewrite references to `.exception` (`PT027`) (#15680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8650.
Test Plan
cargo nextest runandcargo insta test.