Add check command
#15692
Merged
Add check command
#15692
+168
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
carljm,
AlexWaygood and
sharkdp
as code owners
MichaReiser
commented
Jan 23, 2025
| @@ -28,24 +28,22 @@ fn config_override() -> anyhow::Result<()> { | |||
| ), | |||
| ])?; | |||
|
|
|||
| case.insta_settings().bind(|| { | |||
There was a problem hiding this comment.
Some more tidy work. I realised I can use a guard to attach the settings automatically. The only change other than removing the insta_settings method is to call knot check over just knot
dcreager
approved these changes
Jan 23, 2025
| @@ -28,24 +28,22 @@ fn config_override() -> anyhow::Result<()> { | |||
| ), | |||
| ])?; | |||
|
|
|||
| case.insta_settings().bind(|| { | |||
MichaReiser
force-pushed
the
micha/ignore-warn-error-cli-arguments
branch
from
e7a74fb to
61f473d
Compare
Base automatically changed from
micha/ignore-warn-error-cli-arguments
to
main
January 24, 2025 15:20
MichaReiser
force-pushed
the
micha/check-command
branch
from
32f7edb to
1069420
Compare
MichaReiser
force-pushed
the
micha/check-command
branch
from
1069420 to
26f7e46
Compare
dcreager
added a commit
that referenced
this pull request
Jan 24, 2025
* main: Add `check` command (#15692) [red-knot] Use itertools to clean up `SymbolState::merge` (#15702) [red-knot] Add `--ignore`, `--warn`, and `--error` CLI arguments (#15689) Use `uv init --lib` in tutorial (#15718) [red-knot] Use `Unknown | T_inferred` for undeclared public symbols (#15674) [`ruff`] Parenthesize fix when argument spans multiple lines for `unnecessary-round` (`RUF057`) (#15703) [red-knot] Rename `TestDbBuilder::typeshed` to `.custom_typeshed` (#15712) Honor banned top level imports by TID253 in PLC0415. (#15628) Apply `AIR302`-context check only in `@task` function (#15711) [`airflow`] Update `AIR302` to check for deprecated context keys (#15144) Remove test rules from JSON schema (#15627) Add two missing commits to changelog (#15701) Fix grep for version number in docker build (#15699) Bump version to 0.9.3 (#15698) Preserve raw string prefix and escapes (#15694) [`flake8-pytest-style`] Rewrite references to `.exception` (`PT027`) (#15680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the CLI to introduce a dedicated
checkcommand similar toruff check(vs justred_knot <path>)Test Plan
Updated CLI tests