Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PLE2510, PLE2512-2515 to check in f-strings #7387

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Sep 14, 2023

Summary

This PR updates PLE2510, PLE2512-2515 to check in f-strings.

Reference:

  • PLE2510: Invalid unescaped character backspace, use "\b" instead
  • PLE2512: Invalid unescaped character SUB, use "\x1A" instead
  • PLE2513: Invalid unescaped character ESC, use "\x1B" instead
  • PLE2514: Invalid unescaped character NUL, use "\0" instead
  • PLE2515: Invalid unescaped character zero-width-space, use "\u200B" instead

Test Plan

Add test cases for f-strings.

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule python312 Related to Python 3.12 labels Sep 14, 2023
@dhruvmanila dhruvmanila linked an issue Sep 14, 2023 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, why is this a binary file 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, locally I don't see it:

$ ls -la invalid_characters*
-rw-r--r--@ 1 dhruv  staff   1.4K Sep 15 12:02 invalid_characters.py

I guess it's GitHub getting confused although not sure. This is what I see inside the editor:

Screenshot 2023-09-15 at 12 02 44

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvmanila dhruvmanila merged commit e53db6c into dhruv/pep-701 Sep 16, 2023
13 of 16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/issue-7296 branch September 16, 2023 08:11
dhruvmanila added a commit that referenced this pull request Sep 18, 2023
## Summary

This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

## Test Plan

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 19, 2023
## Summary

This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

## Test Plan

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 20, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 21, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 26, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 27, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 28, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python312 Related to Python 3.12 rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PLE2510, PLE2512-2515 to check in f-strings
2 participants