Update PLE2510, PLE2512-2515 to check in f-strings
#7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
added
rule
MichaReiser
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Uh, why is this a binary file 😕
There was a problem hiding this comment.
Weird, locally I don't see it:
$ ls -la invalid_characters*
-rw-r--r--@ 1 dhruv staff 1.4K Sep 15 12:02 invalid_characters.pyI guess it's GitHub getting confused although not sure. This is what I see inside the editor:
There was a problem hiding this comment.
And is also visible in the branch: https://github.com/astral-sh/ruff/blob/dhruv/issue-7296/crates/ruff/resources/test/fixtures/pylint/invalid_characters.py
dhruvmanila
added a commit
that referenced
this pull request
Sep 18, 2023
## Summary This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead ## Test Plan Add test cases for f-strings.
This was referenced Sep 18, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 19, 2023
## Summary This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead ## Test Plan Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 20, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 21, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
This was referenced Sep 22, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 26, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 27, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 28, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings. > ### Reference: > * `PLE2510`: Invalid unescaped character backspace, use "\b" instead > * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead > * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead > * `PLE2514`: Invalid unescaped character NUL, use "\0" instead > * `PLE2515`: Invalid unescaped character zero-width-space, use "\u200B" instead Add test cases for f-strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
PLE2510,PLE2512-2515to check in f-strings.Test Plan
Add test cases for f-strings.