-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pylint
] (Re-)Implement import-private-name
(C2701
)
#9553
Merged
charliermarsh
merged 2 commits into
astral-sh:main
from
tjkuson:fix-import-private-name
Jan 16, 2024
Merged
[pylint
] (Re-)Implement import-private-name
(C2701
)
#9553
charliermarsh
merged 2 commits into
astral-sh:main
from
tjkuson:fix-import-private-name
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes fix for incorrect slice in astral-sh#5920.
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PLC2701 | 501 | 501 | 0 | 0 | 0 |
charliermarsh
approved these changes
Jan 16, 2024
charliermarsh
added
rule
Implementing or modifying a lint rule
preview
Related to preview mode features
labels
Jan 16, 2024
Thank you and sorry that I broke this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5920 with a fix for the erroneous slice in
module_name
. Fixes #9547.Test Plan
Added
import bbb.ccc._ddd as eee
to the test fixture to ensure it no longer panics.cargo test