Skip to content

Commit

Permalink
pip compile: exclude --upgrade-package when option and value are pass…
Browse files Browse the repository at this point in the history
…ed as a single argument (#5033)

This excludes `--upgrade-package` from `compile_command` when value and
option are passed as a single argument. Eg:

```console
--upgrade-package=package
-P=package
-Ppackage
```

I missed this on #5032.
Fixes #5031.

## Test Plan

Tested locally
  • Loading branch information
skshetry committed Jul 13, 2024
1 parent 9997dc0 commit e8c1688
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions crates/uv/src/commands/pip/compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ fn cmd(

// Skip any `--find-links` URLs, unless requested.
if !include_find_links {
if arg.starts_with("--find-links=") || arg.starts_with("-f=") {
if arg.starts_with("--find-links=") || arg.starts_with("-f") {
// Reset state; skip this iteration.
*skip_next = None;
return Some(None);
Expand All @@ -547,7 +547,14 @@ fn cmd(
return Some(None);
}

// Always skip the `--upgrade-package` flag, and mark the next item as skipped
// Always skip the `--upgrade-package` flag
if arg.starts_with("--upgrade-package=") || arg.starts_with("-P") {
// Reset state; skip this iteration.
*skip_next = None;
return Some(None);
}

// Mark the next item as (to be) skipped.
if arg == "--upgrade-package" || arg == "-P" {
*skip_next = Some(true);
return Some(None);
Expand Down

0 comments on commit e8c1688

Please sign in to comment.