Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip compile: exclude --upgrade-package from the header #5032

Merged
merged 1 commit into from
Jul 13, 2024
Merged

pip compile: exclude --upgrade-package from the header #5032

merged 1 commit into from
Jul 13, 2024

Conversation

skshetry
Copy link
Contributor

@skshetry skshetry commented Jul 13, 2024 •
edited
Loading

Summary

Fixes #5031.

Test Plan

Existing snapshot tests should cover it.

@skshetry skshetry force-pushed the exclude-upgrade-package-header branch from da84a7e to a3de7a6 Compare July 13, 2024 03:57
@skshetry skshetry force-pushed the exclude-upgrade-package-header branch from a3de7a6 to ce18a87 Compare July 13, 2024 04:05
@skshetry skshetry marked this pull request as ready for review July 13, 2024 04:10
zanieb
zanieb approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@zanieb zanieb merged commit f770b25 into astral-sh:main Jul 13, 2024
48 of 49 checks passed
@zanieb zanieb added the bug Something isn't working label Jul 13, 2024
@skshetry skshetry deleted the exclude-upgrade-package-header branch July 13, 2024 04:28
@skshetry skshetry mentioned this pull request Jul 13, 2024
Merged
charliermarsh pushed a commit that referenced this pull request Jul 13, 2024
@skshetry
pip compile: exclude --upgrade-package when option and value are pass…
e8c1688 
…ed as a single argument (#5033)

This excludes `--upgrade-package` from `compile_command` when value and
option are passed as a single argument. Eg:

```console
--upgrade-package=package
-P=package
-Ppackage
```

I missed this on #5032.
Fixes #5031.

## Test Plan

Tested locally
@BrewTestBot BrewTestBot mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uv pip compile should exclude --upgrade-package in the header
2 participants
@skshetry @zanieb