Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yank warnings should display at the end #1292

Closed
zanieb opened this issue Feb 13, 2024 · 2 comments · Fixed by #1669
Closed

Yank warnings should display at the end #1292

zanieb opened this issue Feb 13, 2024 · 2 comments · Fixed by #1669
Labels
enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong good first issue Good for newcomers

Comments

@zanieb
Copy link
Member

zanieb commented Feb 13, 2024 •
edited
Loading

We display yank warnings during resolution, but not as a part of the summary at the end. We should probably do it there instead to avoid hiding the message.
@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Feb 13, 2024
@charliermarsh
Copy link
Member

Oops.

@zanieb
Copy link
Member Author

zanieb commented Feb 13, 2024 •
edited
Loading

It looks like #1253 isn't firing at all.

We are showing the warnings from #1253 but they could be re-arranged.

@zanieb zanieb added good first issue Good for newcomers error messages Messaging when something goes wrong labels Feb 18, 2024
@dwreeves dwreeves mentioned this issue Feb 18, 2024
Merged
zanieb pushed a commit that referenced this issue Feb 19, 2024
@dwreeves
Move yank warnings to end of messages (#1669)
e923dba 
Resolves #1292.

## Summary

Move the yanked warnings for `uv pip sync` and `uv pip install` to the
end of the commands, as per #1292.

## Test Plan

I ran the unit tests: `cargo nextest run`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add yank warnings at end of messages dwreeves/uv
2 participants
@charliermarsh @zanieb